- Koha-bugs - lists.koha-community.org

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #21 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Oops sorry I should've thought about that! Understand if this needs to get signed off again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, as the requested changes were only "cosmetic" I'd be ok with keeping this signed off, but was hoping for a separate patch as a follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110227|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110444&action=e… Bug 14367: (follow-up) Rebasing to make patch work on master Run through test plan and confirm everything still works as expected. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110226|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110443&action=e… Bug 14367: (follow-up) Fixing merge conflicts... ...and other fixes to make patch work. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110225|0 |1 is obsolete| | --- Comment #43 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110442&action=e… Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Run updatedatabase.pl * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110224|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 110441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110441&action=e… Bug 14866: Make high holds work with different item types To test: 1) Apply patch, update database, restart services 2) Enable decreaseLoanHighHolds sysprefs if not already active 3) Go to circulation rules and set a value under 'Decrease loan holds (day)' that is DIFFERENT from decreaseLoanHighHoldsDuration 4) Check out an item with holds and confirm that the value from the rule is used instead of the system preference 5) Confirm tests pass before and after the patch t/db_dependent/DecreaseLoanHighHolds.t Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14866] Make high holds work with different item types and number of open days
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26489] New: Holds to pull report fails if SQL strict mode is on
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '20

21 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26489 Bug ID: 26489 Summary: Holds to pull report fails if SQL strict mode is on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: aleisha(a)catalyst.net.nz, gmcharlt(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, kyle.m.hall(a)gmail.com, lucas(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com, testopia(a)bugs.koha-community.org The holds to pull report (/circ/pendingreserves.pl) returns no results if SQL strict mode is on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 22971] New: New location isn't displayed in OPAC for items added in a course reserves
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '20

20 Sep '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22971 Bug ID: 22971 Summary: New location isn't displayed in OPAC for items added in a course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When adding an item in a activated course reserves and you go to see the item details in the OPAC, who can't see the location label after the holding location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5