- Koha-bugs - lists.koha-community.org

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '20

22 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #25 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #24) > > Can you explain a bit more Tomas? > Should not we usually provide "OPAC only" by default, and explicitly pass > the "staff" flag? This is not 'opac only', this is like the 'public' flag on reports, i.e. 'staff only', and the author named it 'opac_display'. The original naming also required to pass it on the query in the OPAC controllers, I just thought it was better to name it different, and so the flipped value also. The default behavior is kept with my follow-up and DB default values. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '20

22 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- If the update entries are idempotent you won't face this problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24657] New: Fix tests of bug 22284 - Groups of pickup locations for holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '20

22 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Bug ID: 24657 Summary: Fix tests of bug 22284 - Groups of pickup locations for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: agustinmoyano(a)theke.io QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Tests in bug 22284 had conditions where they randomly fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '20

22 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #20) > Created attachment 107167 [details] [review] > Bug 5087: (QA follow-up) Rename the attribute to fit later API usage > > This patch renames the introduced attribute for later usage on the API, > and changes the logic to use it the other way around. > > It also adds a KEY for the flag, as it will be used in WHERE statements. > > Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Can you explain a bit more Tomas? Should not we usually provide "OPAC only" by default, and explicitly pass the "staff" flag? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #23 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Rebased the follow-up, boss. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 107169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107169&action=e… Bug 5087: (QA follow-up) Fix leakage in opac-downloadshelf.pl Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #21 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 107168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107168&action=e… Bug 5087: (QA follow-up) used_for deserves an index This patch introduces an index for the used_for column Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #20 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 107167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107167&action=e… Bug 5087: (QA follow-up) Rename the attribute to fit later API usage This patch renames the introduced attribute for later usage on the API, and changes the logic to use it the other way around. It also adds a KEY for the flag, as it will be used in WHERE statements. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5087] Option to not show CSV profiles in OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '20

21 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 107166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107166&action=e… Bug 5087: Ability to define whether CSV profile shows in OPAC To test: 1) Update database 2) Update schema 3) In staff side, go to Tools -> CSV profiles 4) Make a CSV profile with profile type = MARC and usage = Export records 5) Leave 'Show option in OPAC' unchecked and save 6) Go to OPAC and add an item to your cart 7) Click Cart, click Download, confirm that your newly created CSV profile does not show as an option 8) Go back and edit CSV profile on staff side 9) Check the 'Show option in OPAC' checkbox and save 10) Go back to download cart in OPAC 11) Confirm the CSV profile now shows in the dropdown Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0