- Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95853|0 |1 is obsolete| | --- Comment #113 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 106753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106753&action=e… Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24874] New: Printing is broken on opac-results.pl page (19.11.x)
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Bug ID: 24874 Summary: Printing is broken on opac-results.pl page (19.11.x) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org The printing is broken on opac-results.pl page to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 -- You are receiving this mail because: You are watching all bug changes.

1 45

[Bug 21373] New: Checkout not possible when biblio level hold but other items could satisfy it
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21373 Bug ID: 21373 Summary: Checkout not possible when biblio level hold but other items could satisfy it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Assume following 1. There is bib record with 5 items available 2. Patron A makes a bib level hold for the record Now we try to checkout one item from the bib record for patron B Result: I get a warning menu saying that this item is on hold Expected result: I can proceed with the checkout and no warnings come unless there are no available items, i.e., biblio level hold number <= items available. I refactored the C4/Circulation.pm a bit so that we can use the code from CanBookBeRenewd function to make the checkout work the same way as it is possible with renewals, i.e. renewals are possible even if there is a biblio level hold and some other available item that can satisfy the loan. I will send this patch ASAP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 25967] New: Plugin upgrade should remove existing code before installing new code
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25967 Bug ID: 25967 Summary: Plugin upgrade should remove existing code before installing new code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, upgrading a plugin really means overwriting the existing plugin files with new files. This is fine for files that are added or modified, but it won't remove files that have been deleted. Of course, we don't necessarily know what files to delete when we're upgrading a plugin, because we don't track the files, and the files can be a bit messy. For instance, "/var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions" is the root for both KitchenSink and CoverFlow. This is probably an infeasible idea due to existing installs, but just pointing out the flaw in the plugin architecture. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106721&action=e… Bug 25723: (QA follow-up) Silent POD warning I didn't introduce the method that is warned about, but adding POD for it seemed reasonable and will silence the QA Script warning. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106720&action=e… Bug 25723: Remove tests for removed method We removed the exception_holidays (and single_holidays) methods as part of this patchset. As such, we should no longer test them ;) Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106719&action=e… Bug 25723: Update cache flushing calls This patch updates the previous single_holidays and exeption_holidays cache flushing calls to match the new cache key structure of the updated routines. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106718&action=e… Bug 25723: Use the same code for single and exception holidays This patch refactors is_exception_holiday and is_single_holiday to utilise a single _holidays method which combines the logic of the previous single_holidays and exception_holidays methods. As Koha::Calendar is instantiated at a branch level, we also move split the cache into branches too. Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106717&action=e… Bug 25723: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '20

09 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 106716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106716&action=e… Bug 25723: Drop DateTime::Set from cpanfile Signed-off-by: Emma Perks <emma.perks(a)heartofengland.nhs.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0