- Koha-bugs - lists.koha-community.org

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #18 from Joe Sikowitz <joe(a)flo.org> --- Hi Nick, These patches keep things simple and work as expected. Blocker: 1 - If I enter barcodes that are not in any courses I report successful deletion from all courses - I don't think that's right I'm going to fix this one and readd the patch. Couple questions: 1 - Why not a bulk option to remove from a single course? I've already submitted this patch and it has been signed off as bug 25606. 2 - Could the results report which courses the items were deleted from, at the very least maybe the number of courses it was removed from? This sounds reasonable. I'll look into adding it. 3 - I would rather see this use Objects, but CourseReserves could use a refactor as a whole I'm not sure what Objects you are referring to. Any information you can provide would be great. Thanks, Joe -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22823] New: Koha::Library needs a method for obtaining the incoming email address
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 Bug ID: 22823 Summary: Koha::Library needs a method for obtaining the incoming email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There's a code pattern emerging (in bug 5770 and bug 22821 at least to my knowledge) where we grab a branches email address to send notifications to the branch. However, it's prone to make mistakes in the fallback order for assigning that address so we should factor it out into a method that can be called from Koha::Library. Should be as simple as >sub to_email { > my $self = shift; > return $self->branchreplyto || $self->branchemail || C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress'); >} along with some appropriate POD and a walk of the codebase to replace existing occurrences of the pattern. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 46

[Bug 14648] Batch remove reserve items
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Signed Off |Failed QA --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16) > QA team ... I signed off, can one of you take over here please? These patches keep things simple and work as expected. Blocker: 1 - If I enter barcodes that are not in any courses I report successful deletion from all courses - I don't think that's right Couple questions: 1 - Why not a bulk option to remove from a single course? 2 - Could the results report which courses the items were deleted from, at the very least maybe the number of courses it was removed from? 3 - I would rather see this use Objects, but CourseReserves could use a refactor as a whole -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Emmi Takkinen <emmi.takkinen(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #28 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 106624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106624&action=e… Bug 13961: Check that borrowernumber isn't a reference Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors, caused by HASH sometimes set as borrowernumber. Added code to check if borrowernumber is defined and it isn't a reference. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #27 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 106623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106623&action=e… Bug 13961: Fix QA issues This patch fixes following QA issues: FAIL C4/Letters.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL t/db_dependent/Letters.t FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25943] New: Haii
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25943 Bug ID: 25943 Summary: Haii Change sponsored?: --- Product: Koha Version: 19.11 Hardware: HP OS: Other Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: chresstivenrodo(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 106622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106622&action=e… Halo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '20

06 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Pablo AB <pablo.bianchi(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi(a)gmail.com --- Comment #56 from Pablo AB <pablo.bianchi(a)gmail.com> --- On 20.05 this seems to add an untranslatable "Not for loan" near span.notforloan, on MARC21slim2OPACResults.xsl. I reproduce it on Michael Kuhn's Koha demo: 1. On a biblio, add an item to an item type flagged with "not for loan"=Yes 2. Search for it on the OPAC - German: "Verfügbarkeit: Ausleihbare Exemplare: (1). Verfügbarer Präsenzbestand: Not for loan (1).". http://koha.adminkuhn.ch/cgi-bin/koha/opac-search.pl?q=Dictionary - Spanish: "Disponibilidad: Not for loanSignatura topográfica: 520 A552 (1). :". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4030] Patron attribute types cannot be made mandatory
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '20

06 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Good news here! This is implemented, but a little hidden in a patch I just tested: Bug 22844 - Simplify the process of selecting database columns for system preferences *** This bug has been marked as a duplicate of bug 22844 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 25937] New: Notify patrons about failed login attempts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '20

06 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25937 Bug ID: 25937 Summary: Notify patrons about failed login attempts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org We should email/SMS patrons about failed login attempts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3