- Koha-bugs - lists.koha-community.org

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch rebased on master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61210|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 100886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100886&action=e… Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard <nengard(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4985] Edit a calendar entry for all branches
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #15) > I am sorry, I have given this another test run, but I still have issues: > > - Add 2 holidays as 'repeated holidays on a range' > - Try to delete them using 'Delete the repeated holidays on a range.' > - Holidays are not deleted > > With the patch applied, I am not able to delete them. > > Emmi, can you pleas re-check? Confirmed. Everything else works great! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4985] Edit a calendar entry for all branches
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Passed QA |Signed Off --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Oops, did not see Katrin's comment. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4985] Edit a calendar entry for all branches
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98565|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100880&action=e… Bug 4985: Edit a calendar entry for all branches This patch adds functionality to calendar tool to make edits or deletes to all branches at once. To test: -Apply patch -Add holiday for a library and copy it to all or some libraries -Edit previosly made holiday (edit, delete etc.) and check out "Copy changes to all libraries." checkbox => Changes are made to all libraries sharing changed holiday Sponsored by: Koha-Suomi Oy Signed-off-by: Christofer <christofer.zorn(a)ajaxlibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4985] Edit a calendar entry for all branches
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15272] aqbookseller addresses are combined into "physical address" field
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18177 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18177 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 [Bug 18177] Many unused columns in aqbooksellers -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15272] aqbookseller addresses are combined into "physical address" field
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100879&action=e… Bug 15272: Update notice templates for all languages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15272] aqbookseller addresses are combined into "physical address" field
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100878&action=e… Bug 15272: Update notice templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15272] aqbookseller addresses are combined into "physical address" field
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '20

17 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100877&action=e… Bug 15272: Merge aqbooksellers addressX columns The physical address of a vendor is stored in 4 different DB columns: address1, address2, address3 and address4 The are concatenated and split for storage/display purpose. If you enter an address on more than 4 lines, the other lines are truncated: data loss To avoid such weird behavior, we could simplify the code and get more flexibility (like address as long as you wish) merging those 4 columns into 1, address Test plan: 0. Do not apply the patches 1. Create a vendor and enter more than 4 lines in the physical address, save => Notice that the lines has been stored in the 4 columns, and that you lost the end of the address 2. Apply the patches and execute the updatedatabase script 3. Edit the vendor's address => Notice that the address is displayed correctly 4. Add more lines, save => Notice that the extra lines are kept 5. Generate a ACQCLAIM or ACQORDER notice for this vendor => Confirm that the address is displayed correctly in the generated notice -- You are receiving this mail because: You are watching all bug changes.

1 0