- Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99635&action=ed… Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|aleisha(a)catalyst.net.nz |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Failed QA |ASSIGNED --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am trying to submit follow-ups. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Some notes: 1. reportdate must be created_on, with a type "timestamp". 2. opac/opac-reportproblem.pl 112 my $from_address = $member->email || $member->emailpro || $member->B_email || $koha_admin; We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 99633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99633&action=ed… Bug 4461: Rename report date with created_on And make it a timestamp type column -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #101 from David Nind <david(a)davidnind.com> --- Thanks for all the changes Aleisha! When changing facets it now remembers the setting. However, the only thing thing that isn't working is on the staff interface. When you try to go back to the default (Library default: 10) nothing happens, example URL - the number doesn't change, the page doesn't automatically refredh and a # is added at the end of the URL: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?count=20&idx=kw&q=ca… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Emmi Takkinen from comment #16) > (In reply to Jonathan Druart from comment #14) > > I think this new restriction needs to be enforced at module level, when the > > patron is added/updated (Koha::Patron->store), with changes covered by test > > You mean "guarantor can't be guarantee"? And "child patron must have a guarantor". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #100 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Aleisha, what about David's comment? can you please take a look at David'd comment#95?(In reply to Jonathan Druart from comment #99) > Aleisha, what about David's comment? Scratch that! I thought you only added the filters! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #99 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Aleisha, what about David's comment? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #16 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- (In reply to Jonathan Druart from comment #14) > I think this new restriction needs to be enforced at module level, when the > patron is added/updated (Koha::Patron->store), with changes covered by test You mean "guarantor can't be guarantee"? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12133] Guarantor requirements when registering a patron
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '20

26 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #15 from Emmi Takkinen <emmi.takkinen(a)outlook.com> --- Created attachment 99629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99629&action=ed… Bug 12133: Fix issue with modify Child patrons couldn't be modified when guarantor was patron due missing guarantor_id value. This patch fixes that. To test: 1. Add child patron with syspref ChildNeedsGuarantor and GuarantorNeedsToBePatron on. 2. Modify patron and save. 3. Error "Child needs guarantor" is raised even if guarantor exists. 4. Apply patch. 5. Edit again and save. No error should be raised. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0