- Koha-bugs - lists.koha-community.org

[Bug 7882] Add ability to move and reorder fields in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96344|0 |1 is obsolete| | Attachment #96541|0 |1 is obsolete| | Attachment #96542|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96633&action=ed… Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5334] Omnibus: Add explicit foreign key constraints
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 [Bug 24289] Deleting branch will not delete entry in special holidays -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 19233] New: Add ability to send itemnumbers in report results to batch modification
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Bug ID: 19233 Summary: Add ability to send itemnumbers in report results to batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #89 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. I just signed, ~2015 first time, and now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #88 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I am quite ok with this patch, just a couple of things: 1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so. 2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #87 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #86) > Does not work for me: > > Can't use an undefined value as an ARRAY reference at > /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 > DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', > 'HASH(0x5570f6dbc440)', undef) called at > /kohadevbox/koha/admin/marctagstructure.pl line 330 > > CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl:: > StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl > line 284 > eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 Sorry, I forgot the new DB column! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '19

26 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #86 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Does not work for me: Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', 'HASH(0x5570f6dbc440)', undef) called at /kohadevbox/koha/admin/marctagstructure.pl line 330 CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl::StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl line 284 eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 25 Dec '19

25 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96625|0 |1 is obsolete| | --- Comment #85 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 96627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96627&action=ed… Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested on update and new install, works as described. No errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 25 Dec '19

25 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '19

24 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Arthur Bousquet <arthur.bousquet(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92384|0 |1 is obsolete| | --- Comment #84 from Arthur Bousquet <arthur.bousquet(a)inlibro.com> --- Created attachment 96625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96625&action=ed… Bug 8643: Add important constraint to marc subfields I modified the MarcSubfieldStructure.pm file to match the new database shema (with the "important" column) This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

1 0