- Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |maryse.simard(a)inlibro.com --- Comment #98 from Maryse Simard <maryse.simard(a)inlibro.com> --- I rebased the patches. The code has changed a lot with bug 14570, please retest. I've also made some fixes and changed the new system preference AdditionalGuarantorField to GuarantorFields. This way, the system can be set so no information is transfered to the guarantee while adding a guarantor. The test plan for this change is in the patch's commit message. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #97 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93394&action=ed… Bug 12446: (follow-up) Code cleaning Some variable name change, put database update in a perl file, remove unused code and other small fixes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #96 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93393&action=ed… Bug 12446: (follow-up) Remove mandatory transfered values With the new system preference AdditionalGuarantorField, one can add data to be transfered to the guarantee, but cannot remove default ones. This patch renames the syspref to GuarantorFields and set hardcoded default values as the preference's default. To test: 1. After database update, check that the default value for the syspref GuarantorFields contains these columns: streetnumber|address|address2|city|state|zipcode|country| branchcode|phonepro|mobile|email|emailpro|fax 2. Set the value as empty 3. Try adding a guarantor to a patron (from the guarantor's page or the guarantee's): no values should be imported. 4. Check that it still works with different values for the preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #95 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93392&action=ed… Bug 12446: Schema update Category.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90473|0 |1 is obsolete| | --- Comment #94 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93391&action=ed… Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90472|0 |1 is obsolete| | --- Comment #93 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93390&action=ed… Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90471|0 |1 is obsolete| | --- Comment #92 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93389&action=ed… Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90470|0 |1 is obsolete| | --- Comment #91 from Maryse Simard <maryse.simard(a)inlibro.com> --- Created attachment 93388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93388&action=ed… Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20986] New: MARC21 Supplement and Index Textual Holdings don't display
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Bug ID: 20986 Summary: MARC21 Supplement and Index Textual Holdings don't display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Koha currently only displays the 866 Textual Holdings tag. It does not display the 867 Supplements or 868 Indexes Textual Holdings data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 23020] New: Standing Order basket not reflecting payment on order line
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '19

01 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23020 Bug ID: 23020 Summary: Standing Order basket not reflecting payment on order line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When you create a standing order basket in acquisitions, the basket remains open allowing items which arrive regularly to be received. When you create a new order to add to the the standing order basket, in the accounting details you have 2 mandatory fields, the quantity and the fund. The vendor price is not a mandatory field and can be left at 0.00 upon creating the order. This is a common occurrence as a library staff member may not know what the cost will be upon arrival of the item. When a library staff member receives the standing order item they are presented with a screen where they will enter the Actual Cost for the standing order item. Once they enter that price and click save, the price is added to the standing order item. However, if the library staff member views the standing order basket, the column for total tax exc. USD never populates the cost the library staff member entered when receiving the item. The cost does however populate on the invoice details page. We want to provide an effective way for library staff to view the cost of an item without having to click modify on a standing order item. The basket view should include an updated actual cost for each item after it has been received in the acquisitions module. If a standing order item as a zero value when created, when the item is received, with this development the basket view will include the actual cost in the Total Tax exc. (USD) column, if defined and (greater than zero), otherwise show the estimated cost in the standing order basket view. The library should be able to: •enter the Actual Cost for an item in a standing order basket when receiving the item •view the the cost of the standing order item in the basket view under the total tax excluded column •view the actual cost if defined (greater than zero), otherwise view the estimated cost in the standing order basket view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3