- Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #683 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- (In reply to Victor Grousset/tuxayo from comment #679) > > So the RM will not apply this patch and will regenerate & commit the schema files themselves. > > The following commit will cause a conflict and should be squashed with the > "DBIC Schema update" one: Bug 10190: (QA follow-up) add new line at end of > MessageTransportType.pm > > > ------ > > > The QA script report this: > > [FAIL] > koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/CirculationTriggers/ > TriggerContext.vue > FAIL git_manipulation > The file has been added and deleted or renamed in the same > patchset > > Indeed, through the patchset it was created, modified and deleted ^^" > > > --- > > > The test plan should have the commands to run all the relevant tests > > > ---- > > I somehow still have that error >_< > # Failed test 'Expected permissions generated for superlibrarian' > # at t/Koha/Auth/Permissions.t line 315. > # Structures begin differing at: > # $got->{CAN_user_parameters_manage_circ_triggers} = '1' > # $expected->{CAN_user_parameters_manage_circ_triggers} = Does not > exist > > I applied the patches on current main, started a MARC21 KTD (recent image) > on Debian 12 (bookworm) on mariadb 10.11. And ran: > prove t/Koha/Auth/Permissions.t > > What else should I check? > > -- > > And a bunch cypress tests fail > > cypress run --config video=false --spec > t/cypress/integration/Admin/CirculationTriggers_spec.ts > https://paste.evolix.org/ > ?e51bc9bd243787e5#aKPWW8uYFYC5JGmpf4ZTLiCAQnue7HgH2nTvNHJF2RG I'll take the bit I can address here for now: the cypress tests :) I've played around with those a fair bit - seems a lot of the failures had to do with not quite waiting for the data to load ? And some of it was tests still expecting old strings that have been updated. That's sorted now (famous last words). Also added to the existing suite for added coverage. Last I ran them they all passed, so fingers crossed it'll stay that way! :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #682 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 199550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199550&action=e… Bug 10190: (follow-up): test: cypress tests update New tests: - regression: mtt cells render as .fallback (bold italics) - bg-success-subtle highlight on completed steps in the add flow - disabled-Delete states: - patron category filter set - item type filter set - default library, if any library has a trigger higher that default's highest - redirect to admin home if not permitted to access the page - in the edit/add stepper form - check row actions are enabled at the 'selectOrAdd' step - check row actions are disabled once add mode is entered - check the action column is always available on the main page Clean up / general updates: - replace the /api/v1/** catch-all intercept with per-endpoint intercepts so @get-rules waits resolve reliably - remove now-redundant cy.wait("@get-rules") calls - drop unused mount / dayjs / dates imports - ensure expected strings match UI where strings have changed Assisted-by: Claude Opus 4.7 (Anthropic) AI used to draft enhancements tests. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Tests were run multiple times and adjusted iteratively to match code changes, cover regressions as those were found, and handle vue page load. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #681 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 199549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199549&action=e… Bug 10190 (QA follow-up): UI/UX improvements and fixes - phase three Trigger deletion and rule set reset - warn the user that resetting or deleting a given set will break sets using it as fallback. - indicate which sets will be affected. - display a preview of the post reset state of each affected rule set. - preparation: allow TriggerTable to take a title parameter. - refactor to remove 'has_rules' from the store's rule suffixes list so those match the DB. - DRY: refactor to implement TriggerTable rather than use custom templates. - select context stage handles narrower viewports - prevent crash on missing rule set TriggersTable: refactor: the <a> elements used as buttons are now button elements - this is so they may be marked as disabled. Main page - trigger actions (delete button display) - disable the trigger deletion button. - if the context has been narrowed down ('delete' deletes all explicit rule set per trigger per library). - if the trigger belongs to default library AND one or more libraries have a trigger of a number bigger than the selected one. This is to protect trigger sequentiality from being broken for the relevant libraries. We also include an on hover message to explain the disabled button. Add/ Edit trigger form - clarify letters 'undo' button behaviour: - swap the native vue select X for a fa-undo icon. - display 'undo override and reset to fallback' on hover. - only display the add/edit button at the selectOrAdd step. - restore selected trigger yellow highlight (regression fix). - display any temporarily saved data from prior step in a green 'success' container. - only messages and data pulled from the DB for informative purposes display in blue containers. Other - redirect to correct URL (admin home) if store load fails - mtt fallbacks display as such consistently (bold italics) - is a bugfix. - catch errors on store initialisation - remove whitespace duplicate - ensure that mtt, if set, always display Assisted-by: Claude Opus 4.7 (Anthropic) AI used to help trace back potential bug sources, flag potential regressions, and draft enhancements. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14007] Values listed in OpacHiddenItems should not appear in OPAC facets
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Marie-Luce Laflamme <marie-luce.laflamme(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #40 from Marie-Luce Laflamme <marie-luce.laflamme(a)inlibro.com> --- I've tested several times with the 25.05.x version and in latest BibLibre Sandbox, and Koha is still displaying the author, items.ccode, items.location, language, etc. It will also includes the hidden item/record in the facet count when the system preference displayFacetCount is active. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1937] Scan barcode with webcam
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1937 Ruud Steltenpool <r.g.steltenpool(a)saxion.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.g.steltenpool(a)saxion.nl --- Comment #7 from Ruud Steltenpool <r.g.steltenpool(a)saxion.nl> --- I know the open source Zotero (known by many librarians) has something similar on mobile. Maybe it has code that can help Koha. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 39847] New: RealTimeQueue background job doesn't show message in staff interface
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39847 Bug ID: 39847 Summary: RealTimeQueue background job doesn't show message in staff interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: lisette(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 181995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181995&action=e… Current Detailed Message on Hold Queue Update Koha/BackgroundJob/BatchUpdateBiblioHoldsQueue.pm Gives us a message of what biblio ids were updated: data: {"messages":[{"biblio_id":6,"type":"success","code":"holds_queue_updated"}],"report":{"total_success":1,"total_biblios":1},"biblio_ids":[6]} But only a checkbox shows in the detailed message. (See attachment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 17617] New: Confirmation e-mail to patron when hold is placed
by bugzilla-daemon＠bugs.koha-community.org 26 May '26

26 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17617 Bug ID: 17617 Summary: Confirmation e-mail to patron when hold is placed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If an item is purchased from an online shop, the patron will receive a confirmation e-mail of their order. We would like to see something similar in Koha when a hold is placed. We think this would be useful to confirm some key points, for example: - confirm the hold has been added to the system - confirm the title details of the requested item - confirm the collection library - confirm the fee which will be charged for fulfilling the hold - confirm the fee which will be charged if the hold is not collected - explain how to cancel the hold if it's no longer required - explain how to make changes to the hold if any details (e.g. change collection library from AAA to BBB) alter - explain how the patron will be notified when the item is ready for collection There is already a system preference: emailLibrarianWhenHoldIsPlaced - which enables Koha to e-mail the library staff whenever a patron places a hold. Could the code behind this be adapted to e-mail patrons instead, perhaps? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 42690] New: Terminology: "Not held" is ambiguous
by bugzilla-daemon＠bugs.koha-community.org 25 May '26

25 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42690 Bug ID: 42690 Summary: Terminology: "Not held" is ambiguous Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: anneli.osterman(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org CC: lisette(a)bywatersolutions.com, pedro.amorim(a)openfifth.co.uk, tomascohen(a)gmail.com Found while translating: There is a string "Not held" as reason for not filling ILL request. It is not clear what the string means: is it not possible to make a hold, is it not in the collection or something completely different? Is it possible to make the string more clear or at least add some context? https://translate.koha-community.org/translate/koha/main/messages-js/fi/?ch… https://gitlab.com/koha-community/Koha/-/blob/main/koha-tmpl/intranet-tmpl/… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 42688] New: Capitalization: ILL Module
by bugzilla-daemon＠bugs.koha-community.org 25 May '26

25 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42688 Bug ID: 42688 Summary: Capitalization: ILL Module Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 37762 Found while translating main: Show ILL requests that need action. It filters requests by status and library. Provides a button to visit the ILL requests (previously ILL Module). This widget is configurable. Wondering if "previously ILL Module" will be understood by new users? There is also a second appearance of "previously ILL Module" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 [Bug 37762] Expand ILL to allow for supplying agency/lending library workflows -- You are receiving this mail because: You are watching all bug changes.

1 0