- Koha-bugs - lists.koha-community.org

[Bug 4833] Show acquisition information when ordering from suggestion
by bugzilla-daemon＠bugs.koha-community.org 12 May '19

12 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89618&action=ed… Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion This patch adds the budgetname to the return of SearchSuggestion to improve performance. To test: - Same test plan as for the first patch - Verify fund names show in the table - Run t/db_dependent/Suggestions.t -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 May '19

12 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #158 from Michal Denar <black23(a)gmail.com> --- Hi Katrin, OK, one day after. It's sad for me. But I hope that we finish this bug soon. 19.11. will be fine. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 May '19

12 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #157 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Michal Denar from comment #156) > I really love this at 19.05. Aleisa, can you rebase it on master. I'm ready > for test. Hi Michal, we have reached 'feature freeze' - this means no new features will be pushed for 19.05 apart from a select few that the RM has marked with rel_19_05_candidate. See here: http://lists.koha-community.org/pipermail/koha-devel/2019-April/045179.html -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 May '19

12 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #156 from Michal Denar <black23(a)gmail.com> --- I really love this at 19.05. Aleisa, can you rebase it on master. I'm ready for test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #155 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Currently this patch set doesn't apply. Can you please rebase? It might make sense to wait a bit until after the 19.05 release as this will be for 19.11. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15516: Allow to reserve first available item from a group of titles Using index info to reconstruct a base tree... M C4/Reserves.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/placerequest.pl M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging reserve/placerequest.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Reserves.pm Applying: Bug 15516: Holding first available item from x biblios only count 1 reserve Applying: Bug 15516: Update old_reserves (reserve_group_id) Applying: Bug 15516: Set reserve-group.pl to be executable Applying: Bug 15516: Reword 'reserve group' to 'hold group' Applying: Bug 15516: Fix translation issues Applying: Bug 15516: (follow-up) Fix kohastructure.sql Applying: Bug 15516: (follow-up) Fix reserve -> hold change Applying: Bug 15516: (follow-up) Fix modal for hold group error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt). error: could not build fake ancestor Patch failed at 0001 Bug 15516: (follow-up) Fix modal for hold group The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15516-follow-up-Fix-modal-for-hold-group-vopUHO.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22472] New: Should column_exists explode if the table does not exist?
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 Bug ID: 22472 Summary: Should column_exists explode if the table does not exist? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- See bug 18936 comment 33. If C4::Installer::column_exists is called with a table that has been removed, the methods will print an error. I think it should early return if the table does not exist (not an exception, we do not want to make more complex the update DB script) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #32 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531 Bug 14723: Additional delivery notes to messages Review of attachment 87531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=147…) ----------------------------------------------------------------- I took another look at the code and Joseph is right. Made some additional notes too. ::: C4/Letters.pm @@ +912,2 @@ > VALUES > +( ?, ?, ?, ?, ?, ?, ?, NOW(), ?, ?, ?, ? ) I think NOW() might be a MySQLism from my research. @@ +1281,5 @@ > # warn "FAIL: No 'to_address' and no email for " . ($member->{surname} ||'') . ", borrowernumber ($message->{borrowernumber})"; > # warning too verbose for this more common case? > _set_message_status( { message_id => $message->{'message_id'}, > + status => 'failed', > + delivery_note => 'Unable to find an email address for this borrower' } ); See above, these need to be dealt with in the template. ::: installer/data/mysql/atomicupdate/Bug-14723_-_Additional_delivery_notes_to_messages.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE message_queue ADD delivery_note TEXT"); Please use BEFORE or AFTER column to specify where the new column will be added exactly. This will help to keep things the same between new and old installations. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22763] New: Stuck on acquisition
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22763 Bug ID: 22763 Summary: Stuck on acquisition Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: shubham.gupta(a)srdt.co.in QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 88599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88599&action=ed… Stuck on acquisition Hi, As I am new user on koha and proceeding for vendor creation after setup of budget and funds I'm getting an error as attached below. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 8558] Better confirmation message for importing frameworks
by bugzilla-daemon＠bugs.koha-community.org 11 May '19

11 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89491|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 89588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89588&action=ed… Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0