- Koha-bugs - lists.koha-community.org

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 74672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672 Bug 2696: Fine payments should show what was paid for Review of attachment 74672: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=269…) ----------------------------------------------------------------- ::: Koha/Account/Offset.pm @@ +20,4 @@ > use Carp; > > use Koha::Database; > +use Koha::Account::Line; Should be Koha::Account::Lines @@ +39,5 @@ > +=head3 debit > + > +=cut > + > +sub debit { POD missing. @@ +42,5 @@ > + > +sub debit { > + my ( $self ) = @_; > + my $debit_rs = $self->_result->debit; > + return unless $debit_rs; I do not think we should "return unless" here, we do not do that for other methods. Is there a good reason? @@ +50,5 @@ > +=head3 credit > + > +=cut > + > +sub credit { Same as above ::: members/accountline-details.pl @@ +34,5 @@ > + query => $input, > + type => "intranet", > + authnotrequired => 0, > + flagsrequired => { > + borrowers => 1, should be edit_borrowers. @@ +48,5 @@ > +if ($accountline) { > + my $type = $accountline->amount < 0 ? 'credit' : 'debit'; > + my $column = $type eq 'credit' ? 'credit_id' : 'debit_id'; > + > + my @account_offsets = Koha::Account::Offsets->search( { $column => $accountlines_id } ); Would be better to call in scalar context and make the order by created_on here, not template-side. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #142 from Roch D'Amour <roch.damour(a)inlibro.com> --- Created attachment 74756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74756&action=ed… Bug 11317: (follow-up) Add two-level entry to koha-conf and remove unwanted characters - Removed merge marker - Changed include path in favor of using the Asset tt plugin (bug 20538) - Changed access_dir to a two-level entry for clarity Test plans stay the same, just make sure that the two-level configuration entry work properly and everything pass QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10047] Cataloguing search maybe useless?
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Elaine Bradtke <eb(a)efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb(a)efdss.org --- Comment #13 from Elaine Bradtke <eb(a)efdss.org> --- Librarian here: We don't generally use the cataloguing search. I will use it in the test site, to check the reservoir on rare occasions. But the rest of the staff ignore that option. In the odd instances they accidently use that search they are slightly perplexed by the reservoir results. From the perspective of our library - the option of searching the reservoir is useful, but rarely used, and not by the average cataloguer, but by the person who uploads data into Koha. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1. The block reads weird, I would have written: IF we are going to add or remove the librarian flag THEN we check if the loggeed in patron is allowed to But not blocker. 2. I do not think we should shorten syspref's name. Not blocker 3. The descriptions of the 2 options are: - "Do not block permitted non-superlibrarians" - "Allow only superlibrarians" It is negative for "yes" and positive for "no". Native English speakers, sounds ok for you? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Should not we enable this by default for new installations? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 [Bug 20639] Allow setting a default/single backend for OPAC driven requests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should a non-superlibrarian |A non-superlibrarian should |be able to add |not be able to add |superlibrarian privileges? |superlibrarian privileges -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20548 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests -- You are receiving this mail because: You are watching all bug changes.

1 0