- Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #62 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #60) > (In reply to Kyle M Hall from comment #55) > > (In reply to Jonathan Druart from comment #54) > > > Thanks for the follow-ups. > > > > > > (In reply to Jonathan Druart from comment #38) > > > > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING? > > > > How are we going to keep it up-to-date? > > > > I went through the tables looking for columns that represent > > borrowernumbers. It's pretty easy for columns with foreign keys to > > borrowers.borrowernumber, but not all the columns have a borrowernumber. We > > should just add that to the qa process. If a new column is added that is a > > borrowernumber, it should be added to the mapping. We could move the mapping > > itself its own perl module to make it more obvious if you wish. > > I am going to push as it but I am not convinced by this approach. > We will not have any tests to alert us if we forgot to update this mapping. I'm sure we can do two things with unit tests: 1) Automate checking that all borrowernumber fields that are foreign keys to borrowers.borrowernumber are in our mapping 2) Automate testing all non-fk fields that are *named* borrowernumber are in our mapping. As for non-fk fields that are not named bororwernumber, I don't think there is anything we can do. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15273] Fines Payment receipt should include all account lines selected for this pay
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Staff is looking good so far, but ran into an error on the OPAC side: Error while transforming input: xmlXPathCompOpEval: function encode-uri bound to undefined prefix str xmlXPathCompiledEval: 1 objects left on the stack. runtime error: file /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl line 273 element value-of XPath evaluation returned no result. at /home/vagrant/kohaclone/Koha/XSLT_Handler.pm line 208. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Hugh, I've just tested the behaviour on master and things behave correctly for me: if all items are hidden with OpacHiddenItems the record doesn't show in the result list. Only when you try to get to it using a direct link the 404 is shown. If only some items are hidden, the record remains visible and only the items are hidden. Can you retest? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #14 from Hugh Rundle <hughr(a)brimbank.vic.gov.au> --- Ah, yes that probably would be helpful to know! We're using OpacHiddenItems. Should I log a separate bug just for that? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #140 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please fix the errors from the QA script and add the changes to debian/templates/koha-conf-site.xml.in FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns forbidden pattern: merge marker (<<<<<<<) (line 66) OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt FAIL forbidden patterns forbidden pattern: Do *not* include full path to css files, use the Asset TT plugin (bug 20538) (line 5) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 55) OK git manipulation OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #139 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Roch, just something I noticed on another Inlibro bug earlier already: Please provide fixes that QA or RM ask for as separate follow-up patches. This way you can keep the sign-off line on the initial patch. If not told otherwise it's also ok to switch back to Signed-off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20633] New: UseAuthoritiesForTracings syspref isn't taken into account by Unimarc XSL
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20633 Bug ID: 20633 Summary: UseAuthoritiesForTracings syspref isn't taken into account by Unimarc XSL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org UseAuthoritiesForTracings works for MARC21 but doesn't for Unimarc. In Unimarc, if a $9 field is present, the generated link uses it whatever the UseAuthoritiesForTracings value is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 20465] New: misc/export_records.pl add possibility to export by branchcode
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20465 Bug ID: 20465 Summary: misc/export_records.pl add possibility to export by branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: giuseppepassanisi93(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz I was searching a way to export all books holded by a library, in a multi-libraries/single-instance context. I realized a patch to support that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 13445] Clean up options for scheduled reports, remove URL, add HTML and Text/TSV
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '18

22 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Scheduled Report, Type=URL |Clean up options for |fails |scheduled reports, remove | |URL, add HTML and Text/TSV --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Eric, I notice that your author line in the patch reads: phette23 <phette23(a)gmail.com> Do you want to fix it to have your name? It will be listed in the release notes then. I can do it for you if you want to. -- You are receiving this mail because: You are watching all bug changes.

1 0