- Koha-bugs - lists.koha-community.org

[Bug 13498] 'email' templates used for printing slips
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '18

27 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ISSUESLIP, ISSUEQSLIP use |'email' templates used for |'email' template for print. |printing slips -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print.
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '18

27 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus(a)libriotech.no --- Comment #12 from Magnus Enger <magnus(a)libriotech.no> --- This is also a problem when you return a book and click on "Print slip and confirm": the email version of HOLD_SLIP is printed, not the print one. Contrary to what Katrin says in Comment 5, it looks like the email version is both displayed in the popup for printing *and* added to the message_queue. The messages show as "print" and "pending" on the patron account of the patron that has the hold on the book. In this case the print popup displays circ/hold-transfer-slip.pl, which calls C4::Reserves::ReserveSlip(): 54 if ( my $letter = ReserveSlip ($session->param('branch') || $userenv->{branch}, $borrowernumber, $biblionumber) ) { 55 $slip = $letter->{content}; 56 $is_html = $letter->{is_html}; 57 } ReserveSlip() calls C4::Letters::GetPreparedLetter without a message_transport_type parameter: 1886 return C4::Letters::GetPreparedLetter ( 1887 module => 'circulation', 1888 letter_code => 'HOLD_SLIP', 1889 branchcode => $branch, 1890 lang => $patron->lang, 1891 tables => { 1892 'reserves' => $reserve, 1893 'branches' => $reserve->{branchcode}, 1894 'borrowers' => $reserve->{borrowernumber}, 1895 'biblio' => $reserve->{biblionumber}, 1896 'biblioitems' => $reserve->{biblionumber}, 1897 'items' => $reserve->{itemnumber}, 1898 }, 1899 ); And C4::Letters::GetPreparedLetter() assumes email for the missing message_transport_type parameter: 694 my $mtt = $params{message_transport_type} || 'email'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '18

27 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #191 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Alex, patches now apply and updatedatabase works. 1) QA script returns some errors (have removed the OK parts): FAIL t/db_dependent/Koha/Libraries.t FAIL valid Global symbol "$retrieved_category_2" requires explicit package name Global symbol "$nb_of_categories" requires explicit package name t/db_dependent/Koha/Libraries.t had compilation errors. FAIL Koha/StockRotationStages.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/StockRotationRotas.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/StockRotationItems.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/Schema/Result/Stockrotationstage.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Schema/Result/Stockrotationitem.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Schema/Result/Stockrotationrota.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Not sure about the last 3, but please take a look. 2) Missing notice template > I have now implemented all your recommendations and further improved the POD > for the Stockrotation API. > > There are two caveats: > - I have not modified the API file (outside of POD) as it works as is? > - I have not implemented notice template based report for the stockrotation > cronscript. > > For the latter, to be honest, I'm in over my head. If you feel that is a > blocker, then perhaps someone who has worked with the templates before can > point me in the right direction? I have thought about it, but I think we should really not introduce a harcoded notice like this as it will be a step back from what we have achieved now with all messages being translatable. I'd suggest starting at the GUI, taking a look at messages that have recently been added, like the article request ones and see how it was done there maybe? 3) Documentation Can you share how the attached PDF was created? Would it be possible to submit a patch to our manual too? (note: we are using Sphinx now) I read it and thought it was very helpful, but I couldn't figure out what 'Add "in demand"' does, can you explain? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #16 from Jesse Weaver <pianohacker(a)gmail.com> --- (In reply to Jonathan Druart from comment #13) > Waiting for depending bugs that are not signed off yet. > > Jesse, can you provide a remote branch with all the patches applied? https://github.com/pianohacker/koha , branch bz15522-withdeps . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72239|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 72242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72242&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #9 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 72241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72241&action=ed… Bug 15520: (QA follow-up) Add tests, missing installer data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70387|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 72240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72240&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71052|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 72239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72239&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Waiting for depending bugs that are not signed off yet. Jesse, can you provide a remote branch with all the patches applied? -- You are receiving this mail because: You are watching all bug changes.

1 0