- Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #40 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- That was hard but it's rebased (not tested if it still works) After the rebase I checked the diff between the old and new patch to ensure that there was no lost code or mistakenly added. And it was useful as 3 iterations were necessary to have a clean and reliable result. == conflict that could be problematic == <<<<<<< 673a40d2acc5c8c58b7f3e7e6d11c329d0587fc6 <input name="paid" id="paid" value="[% amountoutstanding %]" /> ||||||| merged common ancestors <input name="paid" id="paid" value="[% amountoutstanding | format('%.2f') %]" /> ======= <input name="paid" id="paid" value="[% amountoutstanding | format('%.2f') %]" onchange="Check(document.payindivfine.paid)"/> >>>>>>> Bug 12310 : Modify scripts in order to convert any string to the good format Solved as: <input name="paid" id="paid" value="[% amountoutstanding %]" onchange="Check(document.payindivfine.paid)"/> Maybe the patch is impacted by the fact that the value isn't "format('%.2f')"-ed anymore. This should be found out when testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 248 //Increment the idle time counter every minute. 249 var idleInterval = setInterval(timerIncrement, 1000); // 1 second -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20255] New: deletedbiblio_metadata id should not increment
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20255 Bug ID: 20255 Summary: deletedbiblio_metadata id should not increment Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: rocio(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When restoring bib data from the deletedbiblio_metadata table, you will get a duplicate ID error message. This is because the id field in deletedbiblio_metadata increments rather than keeps the id from the original entry in biblio_metadata. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64696|0 |1 is obsolete| | --- Comment #39 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 72213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72213&action=ed… Bug 12310 : Modify scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Modify the tooltips helping the users entering monrtary information in the right format. Fields on all those pages are now automatically formatted - cgi-bin/koha/admin/aqbudgetperiods.tt - cgi-bin/koha/admin/aqbudgets.tt - cgi-bin/koha/members/mancredit.tt - cgi-bin/koha/members/maninvoice.tt Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #404 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #403) > Created attachment 72008 [details] [review] > Bug 7143: Update about page for new dev - Pongtawat Chippimolchai Pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19806] New: Add class to items.itemnotes_nonpublic
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806 Bug ID: 19806 Summary: Add class to items.itemnotes_nonpublic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Bug 13024 - Nonpublic note not appearing in the staff client added the nonpublic note to the 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) There is currently no class to hide on of those locations if a library wants to hide a non public note. Can we add a class to items.itemnotes_nonpublic so libraries have the choice to hide one of the locations listed above. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #21 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 64704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64704 Bug 8137 - Add Default checkout limit by patron category with priority. Review of attachment 64704: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=813…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +548,5 @@ > no limit applies, except possibly for a limit you define for a specific item type. > </p> > + <p> > + <b>Has priority: </b>If checked, the rule will override those for all branches. Else > + it behaves like a default one: used if no rule existe for the coresponding branch. exists, corresponding. -- typos. @@ +559,4 @@ > <th>Patron category</th> > <th>Total current checkouts allowed</th> > <th>Total current on-site checkouts allowed</th> > + [% UNLESS humanbranch %]<th>Has priority</th>[% END %] humanbranch?! I haven't read the code, but this seems strange to read. ::: t/db_dependent/Circulation/Branch.t @@ +201,5 @@ > + (categorycode, maxissueqty, maxonsiteissueqty, has_priority) > + VALUES( ?, ?, ?, ? ) > +|; > +$dbh->do($query, {}, $samplecat->{categorycode}, 3, 3, 0); > + Why is this change so far away from the other? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 26 Feb '18

26 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #20 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 64891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64891 Bug 8137 - Add default issuing rule for all branches. Review of attachment 64891: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=813…) ----------------------------------------------------------------- ::: t/db_dependent/Koha/IssuingRules.t @@ +50,5 @@ > + ok(Koha::IssuingRule->new({ > + branchcode => $branchcode, > + categorycode => $categorycode, > + itemtype => $itemtype, > + })->store, "Given I added an issuing rule branchcode => $branchcode,' The wording probably should avoid personal pronouns like "I added". "Issuing rule for ... added as expected." is probably better. -- You are receiving this mail because: You are watching all bug changes.

1 0