- Koha-bugs - lists.koha-community.org

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53403|0 |1 is obsolete| | Attachment #53404|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 71929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71929&action=ed… Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19905] New: Don't append wildcard to query terms
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 Bug ID: 19905 Summary: Don't append wildcard to query terms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com Discovered this issue while testing the search links in biblio-details. The links are hard-coded in the template with queries not using quotes for field values, which makes QueryBuilder::_truncate_terms append '*' to the search term. Since wild card searches skips the analyzer-phase, most of our links does not work (since a lot of field values has word boundaries and/or punctuation marks, for example the query "Provider:Taschen," will be converted to "Provider:Taschen,*" and since the indexed value for Provider is "Taschen" this search will produce no results. In my opinion (if I'm not misunderstanding the purpose of this code) appending '*' to words should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Rebased for move of javascript to footer. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71093|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71918&action=ed… Bug 20100: Disallow access to superlibrarian privileges at client side This last patch activates the check at client side. If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be able to change superlibrarian privileges via the interface. Test plan: [1] Enable the pref. [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you cannot add or remove superlib privs. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3777] Field Sizes Inconsistent
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jon Knight from comment #12) > I'm just trawling through old REOPENed cases and I see that the current > (17.05) borrower schema still has the inconsistencies in the addresses. As > this was reopened because it was proving to be an issue for some addresses > longer than 100 characters, is it worth just attacking just those fields to > make them all match the address versions? > > In other words make these field changes in the borrowers table schema: > > B_address mediumtext NOT NULL, > B_address2 text, > B_city mediumtext NOT NULL, > > and > > altcontactaddress1 mediumtext NOT NULL, > altcontactaddress2 text, > altcontactaddress3 mediumtext NOT NULL, I once tried to start a clean-up, but ended very confused. In your eample I think there is probably no reason that ...address2 should not be mediumtext not null too? One thing I encountered back then was that some types can't be using not null (iirc). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|can't place holds on 'on |Can't place holds on 'on |order' items with |order' items with |AllowOnShelfHolds off |AllowOnShelfHolds off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)joensuu.fi --- Comment #60 from paxed <pasi.kallinen(a)joensuu.fi> --- (In reply to Jesse Weaver from comment #57) > Created attachment 70974 [details] [review] > Bug 15395: Example usage of I18N Template::Toolkit plugin > > Moved this patch for example usage to teh end of patch set > and resolved minor conflict while applyin > Signed-off-by: Marc Véron <veron(a)veron.ch> I'm confused by this example. How does the msgid look like in the po-file? msgid "item" msgid_plural "items" Like that? If so, then that's a bad example, as it's basically the same as concatenating number + "item" The number placeholder should be included in the translatable string, so the msgid looks like this: msgid "one item" msgid_plural "%s items" Because the translator can then actually make it sound natural in their own language - perhaps the language needs an article before the number, or a suffix to the number, both of which would be impossible to do with the original example. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15510] New professional cataloguing editor shows OPAC favicon
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '18

19 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- I had some interesting favicon experiences on Bug 20173. Maybe it's related? I think sometimes the browser tries to be too smart for its own good... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '18

18 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18760 -- You are receiving this mail because: You are watching all bug changes.

1 0