- Koha-bugs - lists.koha-community.org

[Bug 19076] New: Renewal via Checkout screen is logged as both a renewal and a checkout
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Bug ID: 19076 Summary: Renewal via Checkout screen is logged as both a renewal and a checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 17708 To recreate: 1 - Enable both issue and renewal logs 2 - Checkout an item to a patron 3 - View the logs - the issue is captured 4 - Checkout the item to the patron again and confirm renewal 5 - Both an issue and a renewal are logged Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708 [Bug 17708] Renewal log seems empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #400 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #399) > Created attachment 71283 [details] [review] > Bug 7143: Fix typo developper vs developer Pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #99 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10032] Uncertain prices hide 'close basket' without explanation
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71374|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71381&action=ed… Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71366|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71380&action=ed… Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71355|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71379&action=ed… Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71354|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71378&action=ed… Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '18

09 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71353|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71377&action=ed… Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0