- Koha-bugs - lists.koha-community.org

[Bug 19284] New: Correct version numbering by adding missing zeros
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19284 Bug ID: 19284 Summary: Correct version numbering by adding missing zeros Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Release tools Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de The release notes will generate the versions as - 16.11.1 - 16.11.2 ... Release maintainers have fixed those manually, but it would be nice if the release notes generated them correctly according to our used schema as: - 16.11.01 - 16.11.02 ... -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #170 from Magnus Enger <magnus(a)libriotech.no> --- Trying to summarize the status of this bug now. *** QA script ** POD coverage Some FAILS are "POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666". It sounds like these can be ignored. ** Atomicupdate FAIL installer/data/mysql/atomicupdate/ill_tables.sql FAIL git manipulation The file has been added and deleted in the same patchset Alex provided ill_tables.sql. Tomas rewrote it as bug_7317_ill.perl. Not sure there is anything to fix here? ** tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt OK forbidden patterns OK git manipulation OK spelling FAIL tt_valid lines 665 FAIL valid_template : not found TT is used to set some HTML attributes. Not sure if this can be fixed. Tomas? *** (In reply to Jonathan Druart from comment #164) > 1/ > +TODO: > + > +- Anything invoking the ->status method; annotated with: > + + # Old use of ->status ! > > What do it mean? OK, according to Tomas. > 2/ I will not make you rewrite everything, but it would have been better to > stay consistent and not mix snake_case and camelCase for method names. OK > First steps with the GUI: > 3/ This is what I see when I enable the module: > https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org > Looks wrong. Not sure if this can be fixed? > 4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got: > Loading failed for the <script> with source > “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. > tablesorter.min.js”. ill-requests.pl:151 > Loading failed for the <script> with source > “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. > checkboxes.min.js”. ill-requests.pl:152 OK. Fixed by Tomas > 5/ Clicked "New ILL request" button and got: > Can't locate Koha/Illbackends//Base.pm OK. Fixed by Tomas. But it sounds like Tomas will be working a bit more on related things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68874|0 |1 is obsolete| | --- Comment #169 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68878&action=ed… Bug 7317: Handle backend absense more gracefuly 5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an exception if the passed backend is invalid. This way we will catch more errors introduced. The patch also disables the 'New Ill request' when no backends are available. Gets rid of a related warning. TODO: Should add a noticeable warning on the UI, or a tooltip on the button. TODO: add a couple tests for the exception 4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include for tablesorter, as this implementation uses Datatables. This is obviously code for older Koha, ported to master. 3/ I know it doesn't look right, but am not sure how to display. This is the usual empty datatable display we have everywhere in Koha. 2/ We could fix it with a proper IDE, I use Komodo and refactoring code is pretty straigh-forward. Worth a separate bug report. 1/ That TODO is misleading. It refers to their own migration from a different design. I checked this code and cannot find occurences of ->status with that annotation. I think this relates to backends code. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '17

01 Nov '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68858|0 |1 is obsolete| | --- Comment #168 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68877&action=ed… Bug 7317: QA followup This fixes some of the issues reported by the QA script, but not all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #167 from Magnus Enger <magnus(a)libriotech.no> --- As far as I can see, these are the remaining problems pointed to by the qa script, that can actually be fixed: FAIL Koha/Exceptions/Ill.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid I think Tomas introduced this in a followup. He can probably add a little bit of POD to it. FAIL Koha/Illrequestattributes.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' OK spelling OK valid FAIL Koha/Illrequests.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' OK spelling OK valid These two files do have some subs that are missing POD. I can look at that again tomorrow. FAIL installer/data/mysql/atomicupdate/ill_tables.sql FAIL git manipulation The file has been added and deleted in the same patchset Not sure how we can fix this without redoing completely the patches from Alex? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt OK forbidden patterns OK git manipulation OK spelling FAIL tt_valid lines 665 FAIL valid_template : not found The codes mixes TT directives and HTML rather intimately: 665 <table 666 [% FOREACH filter IN prefilters %] 667 data-filter-[% filter.name %]="[% filter.value %]" 668 [% END %] 669 id="ill-requests"> Not sure how we can do it differently, though? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #166 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68874&action=ed… Bug 7317: Handle backend absense more gracefuly 5/ This patch is WIP, it makes Koha::Illrequest->load_backend raise an exception if the passed backend is invalid. This way we will catch more errors introduced. The patch also disables the 'New Ill request' when no backends are available. Gets rid of a related warning. TODO: Should add a noticeable warning on the UI, or a tooltip on the button. TODO: add a couple tests for the exception 4/ This patch fixes the path for the checkboxes jquery plugin, and removes the include for tablesorter, as this implementation uses Datatables. This is obviously code for older Koha, ported to master. 3/ I know it doesn't look right, but am not sure how to display. This is the usual empty datatable display we have everywhere in Koha. 2/ We could fix it with a proper IDE, I use Komodo and refactoring code is pretty straigh-forward. Worth a separate bug report. 1/ That TODO is misleading. It refers to their own migration from a different design. I checked this code and cannot find occurences of ->status with that annotation. I think this relates to backends code. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68869|0 |1 is obsolete| | --- Comment #376 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68873&action=ed… Bug 7143: Update 'Koha development team' list Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '17

31 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68868|0 |1 is obsolete| | --- Comment #375 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 68872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68872&action=ed… Bug 7143: Make about.pl knows about the new epoch column Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0