- Koha-bugs - lists.koha-community.org

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 67165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67165 Bug 11300 - Add a new authority linker which searches for authority links on a Z39.50 server. Review of attachment 67165: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- Hi Bouzid, noted some thing in the splinter review. Additionally: - atomicupdate for adding the system preference is missing - You will have to add tests for the new module to pass QA - QA tools show some fails: OK C4/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage OK spelling OK valid FAIL C4/Linker/Z3950Server.pm FAIL critic Found use of Switch. This module is deprecated by the Perl 5 Porters at line 223, column 5. Find an alternative module. OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for flip_heading POD is missing for getZ3950Authority POD is missing for get_link POD is missing for update_cache OK spelling OK valid OK cataloguing/automatic_linker.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon FAIL sysprefs_order Not blocker: Sysprefs AdditionalFieldsInZ3950ResultSearch is bad placed (see bug 10610) - I've tried to configure and test the feature, but see an alert with an internal server error. Plack error logs show: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_cataloguing_automatic_linker_2epl line 65, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. Personal-name,do-not-truncate,ext="K�rger, Walter Christian" ZOOM error 114 "Unsupported Use attribute" (addinfo: "Personal-name") from diag-set 'Bib-1' at /home/vagrant/kohaclone/C4/Linker/Z3950Server.pm line 260. Can't locate object method "get_link" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/vagrant/kohaclone/C4/Biblio.pm line 533. ::: C4/Linker/Z3950Server.pm @@ +15,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use strict; > +use warnings; Please use Modern::Perl instead! ::: installer/data/mysql/sysprefs.sql @@ +8,5 @@ > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), > ('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), > +('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC field/subfields are displayed in -Additional field- column in the result of a search Z3950', 'Free'), > +('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), > +('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), I think there is a merge error here - the new pref (LinkerZ3950Server) is missing and others are doubled up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19437] New: Orphaned QA follow-up: Rearrange CancelExpiredReserves tests
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19437 Bug ID: 19437 Summary: Orphaned QA follow-up: Rearrange CancelExpiredReserves tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 19260] New: Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Bug ID: 19260 Summary: Reservations / holds marked as problems being seen as expired ones and deleted wrongly. Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: r.delahunty(a)arts.ac.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We have the ReservesMaxPickupDelay set to 7 and the ExpireReservesMaxPickupDelay system parameter set to Don’t Allow. Our workflow is that staff use the report generated by waitingreserves.pl to identify titles to retrieve from the Reservations / holds awaiting pickup shelf, and delete the reservation and return the items to the shelf, or have that action trigger reservation satisfaction for the next person in the queue. Since our upgrade for 16.05 to 17.05 we are finding that when we run the cancel_expired_holds.pl job at 01:00 daily, reservations marked as problem ones are being deleted in addition to expired ones (expiration date set by user has been reached, or the default 100 days has been reached). Koha 17.05 appears to be disregarding the ExpireReservesMaxPickupDelay system parameter. (http://translate.koha-community.org/manual/master/en/html/17_cron_jobs.html…) We have suspended this cron job in the meantime, and will write a query to identify expired ones we need to delete. Ideally we want problem reservations NOT to be seen as expired ones. Ray Delahunty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 49

[Bug 19228] New: Confirm delete doesn' t show when deleting an item from course
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19228 Bug ID: 19228 Summary: Confirm delete doesn't show when deleting an item from course Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org The code is there but the confirm box isn't popping up! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 19081] New: Plack preventing uninstalled plugins from being removed on the plugins list
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '17

14 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19081 Bug ID: 19081 Summary: Plack preventing uninstalled plugins from being removed on the plugins list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: ldjamison(a)marywood.edu QA Contact: testopia(a)bugs.koha-community.org When uninstalling a plugin with plack enabled, the plugin remains in the list after uninstall has been selected. It only disappears from the list after restarting plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '17

13 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Dominic Pichette <dominic.pichette(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dominic.pichette(a)inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10748] Add option to block return of lost items
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '17

13 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Dominic Pichette <dominic.pichette(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68034|0 |1 is obsolete| | --- Comment #4 from Dominic Pichette <dominic.pichette(a)inlibro.com> --- Created attachment 68112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68112&action=ed… Bug 10748: Add the ability to block return of lost items Mimicking what does BlockReturnOfWithdrawnItems we can easily add a new syspref to block return of lost items. This patch adds BlockReturnOfLostItems, if set to 'Block' a item marked as lost cannot be checked in. Test plan: 1/ Set BlockReturnOfLostItems to 'Do not block' 2/ Check an item out to a patron 3/ Edit the item and mark it as lost (*) 4/ Check the item in => The item is checked in 5/ Edit the item and remove the lost status 6/ Check the item out again 7/ Edit the item and mark it as lost (*) 8/ Check the item in => The item is not checked in (*) There are 2 ways to mark an item lost: - From the item list view (/catalogue/moredetail.pl?biblionumber=42) If you set the lost status from this form, the issue will be returned Maybe this should be optional (?) - From the edit items form (/cataloguing/additem.pl?biblionumber=42) It is the form you must use to not mark the issue returned. Signed-off-by: Dominic Pichette <dominic(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '17

13 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68090&action=ed… Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '17

13 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68089&action=ed… Bug 9573: Lost items report - Add a new "Export selected items" link -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '17

13 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 68088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68088&action=ed… Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table -- You are receiving this mail because: You are watching all bug changes.

1 0