- Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60675|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61309&action=ed… Bug 9988: Add the cronjob and print an upgrade message The Debian cron file and the misc crontab example are updated. A message is printed when upgrading. Note: At this moment the merge cron job is run once a day. This is imo a good starting point. The load for this job greatly depends on the value of pref AuthorityMergeLimit. Of course you can schedule the job more often, and if this need is felt more globally, we can adjust it later. Test plan: [1] Run the dbrev and see the message. [2] Read the changes to the cron files. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60674|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61308&action=ed… Bug 9988: Refactor the cron script The cron job is moved from migration tools to cronjobs. And renamed to a plural form. The script is now based on Koha objects. It does no longer include the code to merge one record. This can be done via the interface, and will be added to a maintenance script on bug 18071. Should not be part of this cron job. Adding a cron_cleanup method to MergeRequests; this method is called from the cron script to reset older entries still marked in progress and to also remove old processed entries. Tested in a separate unit test. Test plan: [1] Run t/db_dependent/Authorities/MergeRequests.t [2] Set AuthorityMergeLimit to 0. (All merges are postponed.) [3] Modify an authority linked to a few records. [4] Delete an authority linked to a few records with batch delete tool. [5] And select two auth records with linked records. Merge these two records with authority/merge.pl. Note: Do not select Default. See also bug 17380. [6] Check the need_merge_authorities table for inserted records. [7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked records and the record status in need_merge_authorities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60673|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61307&action=ed… Bug 9988: Few subtle changes for postponed merge The fails in the previous test showed that we need the first three changes here. Some final polishing in points 4 to 6. [1] Sub merge: Refine the condition for initializing $tags_new. A postponed 'modify'-merge (A to B) makes that $authtypefrom is not defined when running merge later. When crossing the type boundary, we need a new field too. [2] Sub merge: Add condition for an empty @record_to array. This indicates also that a field should be removed, since we should otherwise only add a $9 subfield. [3] Sub merge: Adjust initializing @record_from. This change is tested by verifying a cleared subfield in the test. [4] DelAuthority: Adding a skipmerge parameter to allow the call from authorities/merge.pl to skip an unneeded merge. This also prevents that the 'delete-merge' would precede the 'modify-merge' under a hypothetical race condition. [5] DelAuthority: There is actually no need to call GetAuthority. The subfields of the old record are not relevant in this case. [6] Added a few POD lines to merge. [7] Removed a trailing space in a comment line in merge. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should no longer fail now. [2] See test plan of next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60672|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 61306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61306&action=ed… Bug 9988: Add a subtest for specific postponed merge issues This subtest shows that we need a few little tweaks to make merge work in some specific postponed merge situations. Test plan: [1] Run t/db_dependent/Authorities/Merge.t. The last subtest should fail. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8548] Add callnumber sort option to overdue report
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60484|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 61302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61302&action=ed… Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski(a)biblibre.com> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8548] Add callnumber sort option to overdue report
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Koha Team AMU <koha.aixmarseille(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha.aixmarseille(a)gmail.com --- Comment #21 from Koha Team AMU <koha.aixmarseille(a)gmail.com> --- Tested on the Biblibre sandbox n°3. In the database : NOTRE DAME DE PARIS / Victor Hugo [Livres] (biblionumber : 974) When we make a suggestion in low-case "notre dame de paris", no warning message, the suggestion is added. When we make a suggestion in upper-case "NOTRE DAME DE PARIS", a warning message appears before validate. It will be better if this patch is not case sensitive. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #49 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #48) > And for UNIMARC it should be 2xx Looks like the stored one is constructed as one-field-record, so the last (...->[-1]) field in this record should always (?) be heading field. Original tag number can be extracted from it as well, but authtypecode can't.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Jesse Maseto <jesse(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse(a)bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #2 from Jesse Maseto <jesse(a)bywatersolutions.com> --- Still seeing the same behavior after the patch is applied. -JesseM -- You are receiving this mail because: You are watching all bug changes.

1 0