- Koha-bugs - lists.koha-community.org

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Blocking temporarily -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jacek Ablewicz from comment #42) > (In reply to Marcel de Rooy from comment #41) > If the search > > my $authfrom = Koha::Authorities->find($mergefrom); > > fails (I'm guessing it will fail, for the postponed "real" merge ?), > $MARCfrom will be ignored, no matter what (it's not used anywhere else in > the merge() subroutine) and @record_from will be empty. Hmm Some doubts starts to arise. Will dig a little bit further.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs(a)lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Any chance of a quick rebase Alex? I'm attempting to QA and I have a SHA1 missing error here ;) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I tested this quite extensively. So I am sure it does not fail :) But I welcome any interest in this patch set.. Please look at the merge call in the updated cron job: + merge({ + mergefrom => $req->authid, + MARCfrom => scalar $req->oldmarc, + mergeto => $req->authid_new, + MARCto => $newmarc, + override_limit => 1, + }); MARCfrom is coming from the adjusted need_merge_authorities table. It contains the report tag (in marcxml). For creation of that record, see Koha::Authority::MergeRequest->new. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- All works as expected and passes qa script checks. Looks good to me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61258|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61290&action=ed… BUG 8010: Removed Auth2.t Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61257|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61289&action=ed… BUG 8010: Correct a few syntax errors, and moved tests - Tests are now in t/db_dependent/Search/History.t - There were 2 differents sysprefs in sysprefs.sql and in atomicupdate => fixed Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61256|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 61288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61288&action=ed… Added a new syspref to Load history to the next user Added a syspref LoadHistory addSearchHistoryToTheFirstLoggedUser to select if you want the system to add the history of searches performed without session when you log in as registered user. TEST PLAN 1 - Search in the catalogue, check you are not logged 2 - Log in : your last history should appear 4 - Log out 5 - Apply the patch 6 - Repeat 1 and 2 7 - Desactivate the syspref addSearchHistoryToTheFirstLoggedUser 8 - Repeat 1 and 2 : your last history shouldn't appear The Unit test doesn't rollback but delete the added lines : the function get_template_and_user allway sets the autocommit to 1. https://bugs.koha-community.org/show_bug.cgi?id=8010 Tested 3 patches together, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '17

20 Mar '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #42 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #41) > Especially the "Few subtle changes" patch makes a few additional refinements > in this regard. I can see an accommodation in this commit for missing $authtypefrom (for a postponed merge, when the old record is already deleted), but it doesn't look quite relevant to empty @record_from ;). I think there may be a problem in the code which is located above that instead, namely my $authfrom = Koha::Authorities->find($mergefrom); my $authtypefrom = $authfrom ? Koha::Authority::Types->find($authfrom->authtypecode) : undef; my $auth_tag_to_report_from = $authtypefrom ? $authtypefrom->auth_tag_to_report : ''; my @record_from; @record_from = $MARCfrom->field($auth_tag_to_report_from)->subfields() if $auth_tag_to_report_from && $MARCfrom && $MARCfrom->field($auth_tag_to_report_from); If the search my $authfrom = Koha::Authorities->find($mergefrom); fails (I'm guessing it will fail, for the postponed "real" merge ?), $MARCfrom will be ignored, no matter what (it's not used anywhere else in the merge() subroutine) and @record_from will be empty. -- You are receiving this mail because: You are watching all bug changes.

1 0