- Koha-bugs - lists.koha-community.org

[Bug 5272] can't import just patron attributes
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com --- Comment #1 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Is this still valid? I don't see the patron attributes options as shown in the screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com Assignee|oleonard(a)myacpl.org |aleishaamohia(a)hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #2 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 58887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58887&action=ed… Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC This patch adds a 'Report a problem' link to the bottom of every page in the OPAC. The user can choose to submit their report to the library or Koha administrator. The report will store the user's problem message, but also their username and the page they were on when they clicked the 'report a problem' link. The patch adds a table 'problem_reports' to the db. To test: 1) Apply patch, update database, rebuild schema 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that one of your libraries has an branch email address. 5) Confirm that the syspref KohaAdminEmailAddress has been filled out. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) First try submitting a problem to the library. Confirm that the fields for 'Problem found on page' and 'Username' are correct, then fill out the 'Subject' and 'Message' and click Submit. 9) Confirm a message shows at the top of the page to show success. 10) Go into mysql and display records from the message_queue table. Confirm that the borrowernumber and subject are correct. Confirm that content shows the message from the problem report, but also the user's username and the problem page. Confirm that the to_address shows the library's email address and the from_address shows the user's email address. 11) Now try submitting a problem to the Koha Admin. Fill fields and click Submit. Confirm message shows at top to show success again. 12) Check message_queue for new problem report. Confirm that the to_address shows the email address from the syspref KohaAdminEmailAddress. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to David Cook from comment #44) > Ah, bug 9580 I'm guessing. > > I really need to look into Coce... ByWater has a coce server that anyone is welcome to use (the more users the more images ready for use) https://coce.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9594] order item subfields in framework
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> --- +1 Marjorie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7654] Add location at opac subscription view
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to M. Tompsett from comment #22) > Comment on attachment 58869 [details] [review] > Bug 7654: Add location at opac subscription view > > Review of attachment 58869 [details] [review]: > ----------------------------------------------------------------- > > Here are some untested thoughts. :) > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > @@ +796,4 @@ > > <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p> > > [% FOREACH subscription IN subscriptions %] > > [% IF ( subscription.branchcode ) %] > > + <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3> > > What if it gets a branch, but someone failed to enter a description or it is > blank? Displaying the branchcode in that case would make sense. I do not > think this correction is correct. That's actually not a problem. The branchcode and branchname are both mandatory. It's not possible to have a branch without a branchname in Koha. Using the TT plugin like this is common in Koha. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7654] Add location at opac subscription view
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #22 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869 Bug 7654: Add location at opac subscription view Review of attachment 58869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=765…) ----------------------------------------------------------------- Here are some untested thoughts. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +796,4 @@ > <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p> > [% FOREACH subscription IN subscriptions %] > [% IF ( subscription.branchcode ) %] > + <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3> What if it gets a branch, but someone failed to enter a description or it is blank? Displaying the branchcode in that case would make sense. I do not think this correction is correct. [% at_library = Branches.GetName( subscription.branchcode ) %] [% SET at_library = subscription.branchcode IF at_library.length=0 %] [% IF at_library %] <h3>At library: [% at_library ) %]</h3> [% END %] @@ -799,5 @@ > - <h3>At library: [% Branches.GetName( subscription.branchname ) %]</h3> > - [% ELSE %] > - [% IF ( subscription.branchcode ) %] > - <h3>At library: [% subscription.branchcode %]</h3> > - [% END %] I'm pretty sure this code was intending to display a branch name if possible, but if not just the branch code. And clearly, it is wrong about that. @@ +813,5 @@ > <p>[% subscription.opacnote FILTER html_line_break %]</p> > [% END %] > + [% IF subscription.location_description || subscription.location %] > + <p>Location: [% IF subscription.location_description %][% subscription.location_description %][% ELSE %][% subscription.location %][% END %]</p> > + [% END %] [% location_description = subscription.location_description %] [% SET location_description = subscription.location IF ! defined location_description || location_description.length=0 %] [% IF location_description %] <p>Location: [% location_description %]</p> [% END %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5250] Various enhancements to web based checkouts
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Agnes Rivers-Moore <arm(a)hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm(a)hanover.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13146] Improve GetRecordValue function by caching field mapping
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 44132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132 Bug 13146 UT Review of attachment 44132: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=131…) ----------------------------------------------------------------- Test::DBIx::Class isn't required to run Koha, just the tests, correct? Probably should skip tests we know we can't run. This will run fine on kohadevbox, but not necessarily on another users koha git box. ::: t/db_dependent/FieldMapping.t @@ +21,5 @@ > +use File::Basename; > +use File::Path; > +use DateTime; > +use Test::MockModule; > +use Test::More tests => 18; Just use Test::More; because of suggested change below. @@ +25,5 @@ > +use Test::More tests => 18; > +use C4::Biblio; > +use Koha::Schema; > + > + use Module::Load::Conditional qw/check_install/; BEGIN { if ( check_install( module => 'Test::DBIx::Class' ) ) { plan tests => 18; # or is it 19... whatever works. } else { plan skip_all => "Need Test::DBIx::Class" } } @@ +43,5 @@ > + _new_schema => sub { return Schema(); } > +); > + > + > +if (0) { What is the point of keeping the code, if it isn't run? @@ +55,5 @@ > +} > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) Multiple side-effects on the same line of code is more difficult to read. @@ +56,5 @@ > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) > + => 'maintitle field mapping properly set for default framework'; While this is valid, given that you did the simpler version of is() below, could this not be: my $fm = Fieldmapping->find( {field => 'maintitle'} ); ok( defined $fm, 'maintitle field mapping properly set for default framework'); instead? This is more readable. @@ +60,5 @@ > + => 'maintitle field mapping properly set for default framework'; > + > +SetFieldMapping('', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {field => 'subtitle'} ) > + => 'subtitle field mapping properly set for default framework'; same here. @@ +70,5 @@ > +}, 'expected fields are there'; > + > +SetFieldMapping('BOOK', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {frameworkcode => 'BOOK', field => 'subtitle'} ) > + => 'subtitle field mapping properly set for BOOK framework'; same here. -- You are receiving this mail because: You are watching all bug changes.

1 0