- Koha-bugs - lists.koha-community.org

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190437&action=e… Bug 3492: (follow-up) Remove last reservefee references Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190436&action=e… Bug 3492: Modernize hold fee system and migrate to circulation rules This commit completely modernizes the hold fee system by migrating from the deprecated categories.reservefee column to the circulation rules framework and implementing modern Koha::Objects patterns. WHAT CHANGED: 1. MIGRATION TO CIRCULATION RULES: - Moved hold fees from categories.reservefee to circulation_rules table - Added database migration script with atomic update - Maintains existing fee amounts during migration - Provides rule hierarchy: category+itemtype+branch specific rules 2. NEW SYSTEM PREFERENCE: TitleHoldFeeStrategy - Options: highest, lowest, most_common - Addresses inconsistent title-level hold fees when items have different fees - Default: 'highest' (safest approach for library revenue) 3. MODERN Koha::Objects API: - Koha::Item->holds_fee($patron): Calculate fee for specific item - Koha::Hold->calculate_hold_fee(): Enhanced item/title-level logic - Koha::Hold->should_charge($stage): Centralized charging logic - Koha::Hold->charge_hold_fee(): Modern fee charging with proper accounting - Removed C4::Reserves::GetReserveFee and ChargeReserveFee 4. ENHANCED FUNCTIONALITY: - Proper ReservesControlBranch logic (patron home vs item home library) - Complete HoldFeeMode implementation (placement/collection/not_always) - Clear OPAC messaging with "You will be charged..." commitment - Comprehensive test coverage for all fee scenarios 5. TECHNICAL IMPROVEMENTS: - Object-oriented design following Koha patterns - Proper error handling and edge case management - Modern test structure with comprehensive coverage - Clean separation between fee calculation and charging TEST PLAN: A) MIGRATION AND SETUP: 1. Apply all patches and run database update 2. Verify existing hold fees migrated to circulation rules: - Administration > Circulation and fine rules - Previous categories.reservefee values now in "Hold fee" column 3. Confirm old categories.reservefee column no longer used B) BASIC FEE CALCULATION: 1. Set up patron categories with different hold fees in circulation rules 2. Create items with different item types, each with different hold fees 3. Test item-level holds charge correct fees based on specific item 4. Test title-level holds use TitleHoldFeeStrategy preference C) TITLE-LEVEL HOLD STRATEGIES: 1. Set TitleHoldFeeStrategy to "highest": - Create title with items having fees $1.00, $2.00, $3.00 - Verify title-level holds charge $3.00 2. Set TitleHoldFeeStrategy to "lowest": - Verify same title charges $1.00 3. Set TitleHoldFeeStrategy to "most_common": - Add multiple items with $2.00 fee - Verify title-level holds charge $2.00 (most common) D) HOLDFEEMODE PREFERENCES: 1. Set HoldFeeMode to "any_time_is_placed": - Place holds and verify immediate fee charging - Check patron account for correct hold fee debits 2. Set HoldFeeMode to "any_time_is_collected": - Place holds, verify no immediate charges - Check out items to patron, verify fee charged on collection 3. Set HoldFeeMode to "not_always": - With available items: verify no fee charged - With all items checked out but no other holds: verify no fee - With all items checked out and other holds exist: verify fee charged E) RULE HIERARCHY TESTING: 1. Set different fees for different category/itemtype/branch combinations 2. Verify most specific rule applies: - Branch + Category + ItemType (most specific) - Category + ItemType - Category only (most general) 3. Test with different patron categories and item types F) USER INTERFACE TESTING: 1. OPAC interface: - Verify "You will be charged..." messages display correct amounts - Test both item-level and title-level hold fee messages - Confirm fees match actual charges in patron account 2. Staff interface: - Place holds for patrons and verify fee calculations - Check Administration > Circulation rules interface works correctly G) EDGE CASES AND ERROR HANDLING: 1. Test $0.00 fees (no charge scenarios) 2. Test patrons with no applicable fee rules (should default to $0.00) 3. Test items with no holdable copies (should return $0.00) 4. Test invalid/missing itemtypes or categories 5. Test holds on biblios with no items H) REGRESSION TESTING: 1. Verify existing hold placement workflows unchanged 2. Check patron account charging remains accurate 3. Confirm OPAC and staff interfaces display correctly 4. Test that existing holds continue to work properly I) UNIT TESTS: Run the following test suites to verify functionality: - prove t/db_dependent/Koha/Hold.t - prove t/db_dependent/Koha/Item.t - prove t/db_dependent/Reserves.t - prove t/db_dependent/Circulation.t BACKWARDS COMPATIBILITY: - All existing functionality preserved - Hold fee amounts maintained during migration - Existing workflows continue unchanged - Legacy code updated to use new API seamlessly Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190435&action=e… Bug 3492: Remove from patron categories admin Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190434&action=e… Bug 3492: Add hold fees to circulation rules system This commit integrates hold fee configuration into the main circulation rules system, providing granular control over hold fees based on patron category, item type, and branch combinations. Changes: - Add hold_fee as a new circulation rule type with full scope support - Remove deprecated reservefee column mapping from Koha::Patron::Category - Integrate hold fee input into the circulation rules admin interface - Add hold fee column to the main circulation rules matrix - Enable proper rule hierarchy resolution for hold fees Hold fees can now be configured at multiple levels with automatic fallback handling following standard circulation rule patterns. Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190433&action=e… Bug 3492: DBIC Update Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 190432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190432&action=e… Bug 3492: Database migration for hold fees to circulation rules This commit adds the database migration to move hold fee configuration from patron categories to circulation rules, providing more granular control over hold fees based on patron category, item type, and branch. The migration: - Creates circulation rules for existing categories.reservefee values - Removes the deprecated reservefee column from categories table Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '25

11 Dec '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189256|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0