November 2012 - Koha-bugs - lists.koha-community.org

[Bug 8880] New: Uninitialized variable triggers error log entry in circulation.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '13

23 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8880 Priority: P5 - low Change sponsored?: --- Bug ID: 8880 CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Assignee: koha-bugs(a)lists.koha-community.org Summary: Uninitialized variable triggers error log entry in circulation.pl Severity: trivial Classification: Unclassified OS: All Reporter: mtompset(a)hotmail.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha I am using bug 8777 as a master bug with several sub-bug reports, as various pieces may be accepted without issue, while others may need rebasing/refixing which would hinder one giant patch. This update overlaps with bug 8826, because the initialization of a hash is within three lines of part of this fix. As such, I have made the same changes in this patch. That is changed the initialization of the hashes from {} to (). To verify potential side effects, I did a search through the circulation.pl file for all occurrences of the variable initialized. This patch initializes $findborrower The error was triggered by trying to substitute on the very next line for an undefined findborrower. An if statement on $findborrow functions the same for undefined and q{}. And TT treats undefined as q{} as well. The || q{} should prevent the error and have no changes in logic. This patch initializes $barcode The error was triggered by trying to substitute on the very next line for an undefined barcode. The if condition on the following line behaves the same for undefined and q{}. The stickyduedate check if condition on $barcode behaves the same. The if condition to check "if we should print" now doesn't generate an error log entry. The inprocess initialization should not trigger an error log now. The next line's if still generates an error log due to a lack of the charges parameter, not due to an undefined barcode. The "STEP 3 : ISSUING" if condition behaves the same. There is no need to check inside the if, because q{} does not run that code (just like undefined didn't). And TT treats undefined as q{} as well. The || q{} should prevent errors and have no changes in logic. This patch initializes $print. Make sure not to confuse it with $printer. :) The "if we should print" if condition no longer generates an error log. However, the if condition containing "$borrowernumber ne ''" still generates an error log, as $borrowernumber is not initialized. Tracing the logic for $borrowernumber is more difficult as external functions are called using it. The || q{} for $print prevents an error and has no effect on the processing logic. Test Plan --------- 1) Login to staff client 2) Circulation 3) Click the 'Check out' link. 4) Go check the error log. Currently under 3.8.5 this generates error log entries for lines: 97,101,163,168,175,610,644, and 660 (in my testing on 3.8.5). 5) apply patch. 6) Home 7) Circulation 8) Click the 'Check out' link. 9) Go check the error log. This should resolve lines 97, 101, 163, and 175 (under 3.8.5) Patches to follow as master and 3.8.x differ. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 8750] New: Chronological terms authorities not correctly indexed
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '13

23 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 Priority: P5 - low Change sponsored?: --- Bug ID: 8750 Assignee: gmcharlt(a)gmail.com Summary: Chronological terms authorities not correctly indexed Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen(a)gmail.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha There's no entry in authority's record.abs for indexing chronological terms. They cannot be searched and (obviously) linked. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 5564] New: UNIMARC plugin for field 4XX fails
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5564 Summary: UNIMARC plugin for field 4XX fails Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt(a)gmail.com ReportedBy: januszop(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org CC: ian.walls(a)bywatersolutions.com Estimated Hours: 0.0 Created attachment 2929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2929 Proposed correcions to unimarc_field_4XX.tmpl There is an error in template file unimarc_field_4XX.tmpl: instead of "UNIMARC Field_4XX.pl" as it is now it should be in every location: "unimarc_field_4XX.pl" Otherwise the plugin fails. Regards, Janusz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 3

[Bug 8321] New: fix OPACShowBarcode description
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321 Priority: P5 - low Change sponsored?: --- Bug ID: 8321 Assignee: nengard(a)gmail.com Summary: fix OPACShowBarcode description Severity: enhancement Classification: Unclassified OS: All Reporter: nengard(a)gmail.com Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha OPACShowBarcode has a description of: Show/Don't show Show items barcode in holding tab. It's repeating the "show" bit. Patch coming fixing this and the grammar on this preference. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 9039] New: Tests in the basic test suite should only test code based on required dependencies/modules
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9039 Priority: P5 - low Change sponsored?: --- Bug ID: 9039 Assignee: gmcharlt(a)gmail.com Summary: Tests in the basic test suite should only test code based on required dependencies/modules Severity: major Classification: Unclassified OS: All Reporter: cnighswonger(a)foundations.edu Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha Tests for optional dependencies should be moved to an "optional" subdirectory wihtin the t directory -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 9050] New: rebuild_zebra should use the adelete action so it doesn't fail when deleting a record not in the index
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Priority: P5 - low Change sponsored?: --- Bug ID: 9050 Assignee: gmcharlt(a)gmail.com Summary: rebuild_zebra should use the adelete action so it doesn't fail when deleting a record not in the index Severity: major Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha >From the man page of zebraidx: delete directory Remove the records corresponding to the files found under directory from the register. adelete directory Remove the records corresponding to the files found under directory from the register. Unlike command delete this command does not fail if a record does not exist (but which is attempted deleted). -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 8892] New: Plack variable scoping in basket.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8892 Priority: P1 - high Change sponsored?: --- Bug ID: 8892 Assignee: paul.poulain(a)biblibre.com Blocks: 7172 Summary: Plack variable scoping in basket.pl Severity: major Classification: Unclassified OS: All Reporter: paul.poulain(a)biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha Variable "$basketno" is not available at /home/paul/koha.dev/koha-community/acqui/basket.pl line 359. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 9054] New: 00-load should not try to load modules with optional dependencies
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9054 Priority: P5 - low Change sponsored?: --- Bug ID: 9054 Assignee: jcamins(a)cpbibliography.com Summary: 00-load should not try to load modules with optional dependencies Severity: critical Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha At the moment, t/00-load.t is trying to load Koha::SearchEngine, which failes when Moose is not installed. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 9036] New: 00-load.t checks Koha::Cache::Memcached when it should not
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9036 Priority: P5 - low Change sponsored?: --- Bug ID: 9036 Assignee: gmcharlt(a)gmail.com Summary: 00-load.t checks Koha::Cache::Memcached when it should not Severity: normal Classification: Unclassified OS: All Reporter: cnighswonger(a)foundations.edu Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha Memcached related modules are optional, not mandatory, so we should not be testing related code in the basic test suite. ------------------ $ prove t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... 2/? Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Barcodes/hbyymmincr.pm line 41. Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/External/BakerTaylor.pm line 42. t/00-load.t ......................... 133/? # Failed test 'use Koha::Cache::Memcached;' Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' # at t/00-load.t line 48. # Tried to use 'Koha::Cache::Memcached'. # Error: Can't locate Cache/Memcached/Fast.pm in @INC (@INC contains: /home/cnighswonger/Repositories/koha.3.2.labels/ /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # BEGIN failed--compilation aborted at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # Compilation failed in require at (eval 1325) line 2. # BEGIN failed--compilation aborted at (eval 1325) line 2. # Tests were run but no plan was declared and done_testing() was not seen. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 6836] New: jQuery plugin Datatables integration
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '13

22 Apr '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 Bug #: 6836 Summary: jQuery plugin Datatables integration Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt(a)gmail.com ReportedBy: julian.maurice(a)biblibre.com QAContact: koha-bugs(a)lists.koha-community.org The coming patch add the javascript library, a CSS (and image files from datatables.net) and another javascript file which provides some extra features. It also add a Perl module C4::Utils::Datatables which provides helpful functions for server-side processing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 64