February 2014 - Koha-bugs - lists.koha-community.org

[Bug 11393] New: Language menu not show up as name for Thai (th-THA was shown)
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Bug ID: 11393 Summary: Language menu not show up as name for Thai (th-THA was shown) Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pongtawat.c(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr When Thai translation is installed and enabled. The language menu at the bottom of OPAC screen shown up as language code "th-THA". Also, the preference "language" and "opaclanguage" also show up as "(th-THA)". However, if I change the Thai template folder from "opac-tmpl/prog/th-THA" to "opac-tmpl/prog/th", the language menu, as well as the preferences, will display entry for Thai as "ภาษาไทย" which is correct. So, I don't know if there is some value missing (or incorrect) in database for "th-THA" or that the translation template should be "th". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 6374] New: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Bug #: 6374 Summary: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: januszop(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org In many places the name "size" is used as hash key when the hash is passed to the template system for display. So, for example, since "size" is used as a name of a column of bibioitems table, it appears (or not, depending on if it was defined or not) in elements of SEARCH_RESULTS (in catalogue/search.pl or opac-search.pl) and is passed to the template results.tt/opac-results.tt. Then, in [opac-]results.tt a test is being done: [% IF ( SEARCH_RESULT.size ) %] Now: if "size" was defined, everything is OK and the size will be displayed (e.g. 21 cm), BUT if it was not defined, then a "random" number appears. This is because "size" is one of the virtual methods defined in Template::Toolkit for every data type (cf. http://search.cpan.org/~abw/Template-Toolkit-2.22/lib/Template/Manual/VMeth…) So, if "size" was defined by Koha, it will overload the method, but if it was not, then 1) XXX.size exists anyway, 2) the virtual method size() is called -- and it returns the number of elements in the hash or loop etc., depending on what is referred. The number of suspicious similar spots is ca. 20: git grep "IF.*\.size" called in koha-tmpl The issue does not seem to me to be straightforward to resolve, so I am not proposing any patch at the time. Since it seems that in most of the cases it rooted in biblioitems.size column, maybe it would be the simplest to rename that column to 'format' (and make appropriate changes in the code)? Any other ideas? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 27

[Bug 10466] New: Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466 Bug ID: 10466 Summary: Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au This is an old bug that has been spotted again. This time, it's been noticed in the Lists/Virtual Shelves... Basically, itemsloo.size produces different results depending on the type of data that is in the itemsloo hash (within the itemsloop array): 1) If "size" has a value, that value will be printed out. 2) If "size" is null/undef, a seemingly random number will print out. 3) If there is no "size" key in the hash, a seemingly random number will print out. (N.B. In fact, this "random" number is the number of keys in the itemsloo hash. "Size" is a virtual method in the template toolkit. http://www.template-toolkit.org/docs/manual/VMethods.html.) -- Currently, elsewhere in Koha (bug 6374 which covers search.pl, addbooks.pl, opac-search.pl), we're checking to see if a "size" key exists, and if not, we're inserting a "size" key with a value of "". In this case, as long as the SQL query includes the size column, there will always be a "size" key (so scenario 3 is irrelevant). We need to check if "size" is "defined", and if it's not (scenario 2 from above), then we change it to a blank (e.g. "") value, so that it just prints out nothing. The fact that "size" does print a value is probably a bug in TT, so I don't think this is the best long-term solution. It would probably make more sense to rename the variable that we're passing to TT, because if TT gets "fixed" so that "size" always operates as a method rather than fetching the value of a hash, we are going to have to do this all over again. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 11801] New: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Bug ID: 11801 Summary: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 7386] New: Label batches cannot be batch deleted
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Bug #: 7386 Summary: Label batches cannot be batch deleted Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing AssignedTo: cnighswonger(a)foundations.edu ReportedBy: nflanagan(a)maine.rr.com QAContact: ian.walls(a)bywatersolutions.com Currently label batches must be deleted individually. Selecting several batches and clicking the delete button gives the error: "Please select only one batch todelete." It would be a nice enhancement to be able to delete multiple batches at once. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 7

[Bug 11878] New: Eliminate use of deprecated jQuery .toggle() method usage
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11878 Bug ID: 11878 Summary: Eliminate use of deprecated jQuery .toggle() method usage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org There are a few instances in the templates of the .toggle() method usage which is now deprecated: http://jquery.com/upgrade-guide/1.9/#toggle-function-function-removed These will need to be corrected before we can upgrade jQuery. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 11806] New: Use validation plugin when creating new OAI set
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806 Bug ID: 11806 Summary: Use validation plugin when creating new OAI set Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/oai_sets.pl?op=new OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The new OAI set entry form shows that two fields are required but does not enforce this requirement. This can be handled client-side with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/) -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 9230] New: selectively delete reading history
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230 Bug ID: 9230 Summary: selectively delete reading history Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be nice if you could selectively delete your reading history as a patron. Checkboxes or something on your reading history to delete some things but not all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 9261] New: Allow librarians to make purchase suggestions for patrons
by bugzilla-daemon＠bugs.koha-community.org 18 Jun '14

18 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Bug ID: 9261 Summary: Allow librarians to make purchase suggestions for patrons Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com It would be nice if librarians could make purchase suggestions in the name of a give patron. Some reasons we've been given: * We have many patrons in rural areas that do not have computers/Internet. * Others are homebound as well. They receive items through our mailorder service and place orders exclusively by phone or mail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 46

[Bug 9393] New: Fix bad label and add note to circulation.pl if borrower has pending modifications
by bugzilla-daemon＠bugs.koha-community.org 17 Jun '14

17 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Bug ID: 9393 Summary: Fix bad label and add note to circulation.pl if borrower has pending modifications Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com * Change 'mobile phone' to 'other phone' * Run typed in captcha through uc before comparing. * Add note to circulation.pl if borrower has pending modifications -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12