May 2015 - Koha-bugs - lists.koha-community.org

[Bug 12719] New: Fix bulkmarcimport.pl "keepids" documentation
by bugzilla-daemon＠bugs.koha-community.org 07 May '15

07 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12719 Bug ID: 12719 Summary: Fix bulkmarcimport.pl "keepids" documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Currently, there are two entries for "keepids" in the perldoc for bulkmarcimport.pl. The following code here is (mostly) correct: 713 =item B<-k, -keepids>=<FIELD> 714 715 Field store ids in I<FIELD> (usefull for authorities, where 001 contains the 716 authid for Koha, that can contain a very valuable info for authorities coming 717 from LOC or BNF. useless for biblios probably) The following code here is really NOT: 747 =item B<-keepids> 748 749 Store ids in 009 (usefull for authorities, where 001 contains the authid for 750 Koha, that can contain a very valuable info for authorities coming from LOC or 751 BNF. useless for biblios probably) -- It should probably be something like... =item B<-k, -keepids>=<FIELD> Keep the ID (i.e. control number 001) from the incoming record in I<FIELD>. I<FIELD> should be a field/subfield pair, such as 035a, or a controlfield, such as 009. If no I<FIELD> is provided, the 001 from the incoming record will be kept in the 001 in Koha. (N.B. I don't know if a FIELD-less parameter would result in a bug or not...) -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 14061] New: Inventory fails to map withdrawn authorized values
by bugzilla-daemon＠bugs.koha-community.org 07 May '15

07 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Bug ID: 14061 Summary: Inventory fails to map withdrawn authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org if ($f and $sf) fails if: $f is NULL,'', or 0 and similarly with $sf. 952$0 = withdrawn status. This should be (defined $f and defined $sf). -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 11270] New: Search Result highlighting should be refactored
by bugzilla-daemon＠bugs.koha-community.org 07 May '15

07 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270 Bug ID: 11270 Summary: Search Result highlighting should be refactored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: campbellreidtait(a)gmail.com, chris(a)bigballofwax.co.nz, gitbot(a)bugs.koha-community.org, jonathan.druart(a)biblibre.com, katrin.fischer(a)bsz-bw.de, kyle(a)bywatersolutions.com, martin.renvoize(a)ptfs-europe.com, paul.poulain(a)biblibre.com, savitra.sirohi(a)osslabs.biz, spalding(a)senylrc.org Depends on: 6149 Whilst working on Bug 6149 I found there to be many repeats of code in different file relating to the search highlighting. This patch tries to factor out some of the code into include's to enhance maintainability. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #42 from M. Tompsett <mtompset(a)hotmail.com> --- This is a rebase. The last patch (Follow up: Add sample letter to other languages) is what addresses Kyle's comment #36. The first two patches have passed QA, the last one needs sign off. prove xt/sample_notices.t might be in order too. :) If there is a failure, check if bug 14119 has been applied, since I discovered a problem elsewhere. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36720|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 38910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38910&action=edit Bug 1985 - Follow up: Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36678|0 |1 is obsolete| | --- Comment #40 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 38909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38909&action=edit Bug 1985 - tweak License and lots of cleanup In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Review.t 7) Run the koha qa test tool. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36677|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 38908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38908&action=edit Bug 1985 - Email notification of new OPAC comments This feature adds YAS 'CommentModeratorsEmail', where an email (template code COMMENT_CREATED) is sent when a borrower creates/modifies an comment/review. The syspref is empty by default and no email is sent when the syspref is empty. This feature is needed because we want to alert our content moderators to take action when needed. Usually it is our librarians who write reviews and this improvement makes the process of moving Koha reviews to our CMS more smooth. TEST SETUP: -1. Run updatedatabase.pl to add the syspref and the new letter template. 0. Go to admin/preferences.pl?tab=opac, and set the 'CommentModeratorsEmail'-syspref to your email-address. TEST PLAN: 1. Log in to OPAC and find any Biblio. 2. Make a comment/review for it. 3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'. You should see the reasonable default message. You can change the message in tools/letter.pl. NOTE: Tested in conjunction with my patch. However, this piece alone: - lacked unit tests since it modified C4/Review.pm - failed to provide the desired links in the email message, as mentioned in comment #1. - failed to pass biblionumber information for use in the letter as mentioned in comment #11. - passed $review, when it was really id that should have been passed and used to implement the inclusion of reviews.reviewid and other reviews table fields. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: sonia bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2969] Report Name should be mandatory for saved reports
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Pablo AB <pablo.bianchi(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)pttk.fi --- Comment #15 from Pablo AB <pablo.bianchi(a)gmail.com> --- *** Bug 12213 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 12213] New: Creating a report with unnamed report group shows strange "disconnected" tab
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12213 Bug ID: 12213 Summary: Creating a report with unnamed report group shows strange "disconnected" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org Created attachment 28042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28042&action=edit "Disconnected" reports group tab When creating a new report, create a new report group, but do not give the group any name. The unnamed group will show up as a "disconnected" tab. See attached image. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 13767] New: Readonly::XS (1:02) is not installed
by bugzilla-daemon＠bugs.koha-community.org 06 May '15

06 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Bug ID: 13767 Summary: Readonly::XS (1:02) is not installed Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: isabelaterra(a)cp2.g12.br QA Contact: testopia(a)bugs.koha-community.org I'm really looking for some help here, please, my brain (whatever is left!) Is swimming in Perl code. All perl modules are present (except tells me que Readonly :: XS (1:02) is not installed, but I have 1.05), permissions Have Been verified, ps -u koha shows the daemon and zebrasrv running, mysqlcheck is clean, etc. Searches return empty and analytical reports report that is registered in the database. I'm using Debian 7 u3 and Koha 3.18. -- You are receiving this mail because: You are watching all bug changes.

1 21