February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15374] Translatability: Fix issues on OPAC summary page
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47678|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47772&action=ed… Bug 15374 - Translatability: Fix issues on OPAC summary page Fix several issues on opac-user.tt with sentences splitted by tags, leading to odd translations. Additionally, fix a broken link that should point to opac-account.pl To test: - Apply patch - Log in to OPAC - with blocked /debarred user (with and without comment and date) - with user who has to much fines - with user who has his card marked as lost - with user with an account that is about to expire - with user with expired account - with user with uncertain address information - with user who has got a circulation message (from checkout page) - with user who has a OPAC note - Verify that information is correct and displays nicely and that links in messages work - Carefully examine code - Search for regressions (Amended to add price formatting in fines tab label) Can see the warning message now :) signing off Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> (Amended to make patches apply, see comment #12) Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> (Amended to make it apply and to fix BORROWER.INF -> BORROWER->INFO. Needs new sign-off. / MV) (Amended to fix typo from comment #24 / mv) Amended to fix merge conflict -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15374] Translatability: Fix issues on OPAC summary page
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374 --- Comment #28 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Marc Véron from comment #27) > Hi Aleisha, > Thank you very much for continuous testing. > > I could not reproduce your issue from comment #24, see my tests in comment > #25. If I missed something, please provide information on how you got your > result. > Hi Marc, I mean that when a user has been blocked from checkouts because their fine balance is over the limit, I feel like a message should show up saying this, regardless of if OpacRenewalAllowed is set to Allow or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46091|0 |1 is obsolete| | --- Comment #15 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47771&action=ed… Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #14 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47770&action=ed… Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> https://bugs.koha-community.org/show_bug.cgi?id=12478 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47627|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47769&action=ed… Bug 15311 - Let libraries set text to display when OpacMaintenance = on Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online Moving code to atomic update and fixing merge conflict -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #209 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx Julian! -- You are receiving this mail because: You are watching all bug changes.

1 0