February 2016 - Koha-bugs - lists.koha-community.org

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #193 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47768&action=ed… Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #192 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47767&action=ed… Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Aleisha, don't worry about it. If you don't get around to it, we can fix it too later on. - Or the person fixing the database update can. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Jason Burds <jburds(a)dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jburds(a)dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11405] Inventory tool enhancements
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Jason Burds <jburds(a)dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jburds(a)dubuque.lib.ia.us --- Comment #51 from Jason Burds <jburds(a)dubuque.lib.ia.us> --- Working on the test plan, I was not able to get it to pass using the sandbox. Compare barcodes list to results doesn't work. Tried using an txt file with 5 items in it. There are 6 items with the call number FIC. I get stuck on number 6. 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #21 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Olli-Antti Kivilahti from comment #20) > See the attached opendocument presentation about the pros and cons of the > two different approaches. > > If you like this approach, sign off this patch. While I may prefer the individual file for the reason of reducing potential conflicts, I still can't sign off for the very reason given in comment #19. "This patch still applies, but there is no "t/Exceptions.t" test file. I think this should be required for a sign off" Additionally, it has usually been the case that if one method is used first in Koha that either: a) you do it the way already there, OR b) you refactor the other way AFTER discussion on koha-devel. So, if (b) is the choice, then create a refactor bug, and make this depend on that. And of course, actually discuss this on koha-devel. And either way, there should be a test file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15629 --- Comment #30 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Patches rebased on top of bug 15629. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 [Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3 -- You are receiving this mail because: You are watching all bug changes.

1 0