February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44952|0 |1 is obsolete| | --- Comment #48 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 47779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47779&action=ed… Bug 14395: Unit tests This patch adds test cases for the new syspref NoRenewalBeforePrecision. Tests if GetSoonestRenewDate returns correct values for both 'date' and 'exact_time' settings. Also adds a few comments related to bugs 7413 and 14101. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44951|0 |1 is obsolete| | --- Comment #47 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 47778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47778&action=ed… Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44950|0 |1 is obsolete| | --- Comment #46 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 47777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47777&action=ed… Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47774|0 |1 is obsolete| | --- Comment #20 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47776&action=ed… Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44533|0 |1 is obsolete| | Attachment #47773|0 |1 is obsolete| | --- Comment #19 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47775&action=ed… Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47771|0 |1 is obsolete| | --- Comment #18 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47774&action=ed… Bug 12748 - Add test for step 7 and 8 and rename findSerialByStatus https://bugs.koha-community.org/show_bug.cgi?id=12478 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47770|0 |1 is obsolete| | --- Comment #17 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47773&action=ed… Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12748] Serials - two issues with status of "Expected"
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia(a)hotmail.com --- Comment #16 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- CONFLICT (content): Merge conflict in t/db_dependent/Serials.t Patch failed at 0001 Bug12748 - Fixes duplicate serials with an "expected" status bug -- You are receiving this mail because: You are watching all bug changes.

1 0