February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15311] Let libraries set text to display when OpacMaintenance = on
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47769|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47784&action=ed… [SIGNED-OFF] Bug 15311 - Let libraries set text to display when OpacMaintenance = on Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online Moving code to atomic update and fixing merge conflict NOTE: Accounted for an SQL typo and autoescaping of the template. If someone else could test this, then I would be fine with marking it signed off. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3144] anti-spam for opac-suggestions
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #38 from Christopher Vella <chris(a)calyx.net.au> --- > > One idea could be to IP ban any user who submits > > content to that form (I don't see any reason why a normal user would). > > I'm not sure I understand what you mean here. When the user fills out the > form, their browser would be POSTing the data to the Koha server, so it > would be something a normal user would do. Normal users shouldn't be submitting any data to the negcap field (because its not visible). Therefore only spammers should be submitting data too it. If we introduced a banning system, their subsequent spamming attempts would be stopped. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #67 from M. Tompsett <mtompset(a)hotmail.com> --- I wasn't attempting to gauge the prettiness of the UI for this sign off. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #66 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47782&action=ed… [SIGNED-OFF] Bug 10988: Tabs vs Spaces qa failure patch Run Koha QA Test tools and discovered this failed because of tabs. Rather than fail this and wait forever for it to get fixed, this patches it, and I'll mark it as signed off anyways. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #65 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47781&action=ed… [SIGNED-OFF] Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #64 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 47780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47780&action=ed… [SIGNED-OFF] Bug 10988 - Fixes for comments 57 and 58 Test Plan (remains the same): 0) Back up your database 1) Apply all these patches 2) In your mysql client use your Koha database and execute: > DELETE FROM systempreferences; > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql; -- Should be no errors. > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see 4 entries. > QUIT; 3) Restore your database 4) Run ./installer/data/mysql/updatedatabase.pl; 5) In your mysql client use your Koha database and execute: > SELECT * FROM systempreferences LIKE 'GoogleO%'; -- Should see the same 4 entries. 6) Log into the staff client 7) Home -> Koha administration -> Global system preferences 8) -> OPAC -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca) 9) -> Administration -- There should be a 'Google OAuth2' section with the ability to set those 4 system preferences. 10) In a new tab, go to https://console.developers.google.com/project 11) Click 'Create Project' 12) Type in a project name that won't freak users out, like your library name (e.g. South Pole Library). 13) Click the 'Create' button. 14) Click the 'APIs & auth' in the left frame. 15) Click 'Credentials' 16) Click 'Create new Client ID' 17) Select 'Web application' and click 'Configure consent screen'. 18) Select the Email Address. 19) Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) 20) Fill in the other fields as desired (or not) 21) Click 'Save' 22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://library.yourDNS.org) 23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleopenidconnect) 24) Click 'Create Client ID' 25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID system preference. 26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret system preference. 27) Change the GoogleOpenIDConnect preference to 'Use'. 28) Click 'Save all Administration preferences' 29) In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. 30) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15762 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '16

08 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 --- Comment #6 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #5) > Tests failed: > StandingOrders.t > CancelReceipt.t > OrderUsers.t > > Also I can still see the quantity field there, just can't change it > > Otherwise everything else seems to work well and will be happy to sign off > once those few things are fixed up :) Could you please post the full test output (using prove -v)? -- You are receiving this mail because: You are watching all bug changes.

1 0