February 2016 - Koha-bugs - lists.koha-community.org

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42534|0 |1 is obsolete| | --- Comment #24 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47593&action=ed… Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use GetBasketAsCSV instead GetBasketAsCSV now has a new argument the profile_csv_id, when this param is defined, it loads the profile_content, searches the value of the predefined fields and assembles the data to create the output of the csv file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42533|0 |1 is obsolete| | --- Comment #23 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47592&action=ed… Bug 8612 - Cleans basket.tt by using TT blocks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42532|0 |1 is obsolete| | --- Comment #22 from Rémi Mayrand-Provencher <remi.mayrand-provencher(a)inLibro.com> --- Created attachment 47591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47591&action=ed… Bug 8612 - System preference to have custom fields in export csv basket This patch allows the user use a CSV export profile to create the fields to export the basket as CSV in a basket page. To test: 1) Apply the patch; 2) Create a CSV export profile - type sql - Home › Tools › CSV export profiles ex: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) Create a new basket and add an order to the basket 4) Validate: the text "Select CSV profile:" and a dropdown in the basket view 5) In the new dropdown, select the CSV export profile created 6) Validate the CSV file. 7) Do the same validation with a closed basket. a) close the basket b) View the basket c) validate that there is a dropdown d) test it with an export Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Works as expected for me -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14616] Introducing Koha::Object subclasses
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47565|0 |1 is obsolete| | --- Comment #40 from Marc Véron <veron(a)veron.ch> --- Created attachment 47590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47590&action=ed… Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Tested all patches together. Wors as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47564|0 |1 is obsolete| | --- Comment #39 from Marc Véron <veron(a)veron.ch> --- Created attachment 47589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47589&action=ed… Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12426] Allow resending of emails from the notices tab in the patron account
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #38 from Marc Véron <veron(a)veron.ch> --- Created attachment 47588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47588&action=ed… Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5260] It would be nice if Koha's Acquisition module could order by email
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0