February 2016 - Koha-bugs - lists.koha-community.org

[Bug 13486] About page Apache version is empty if Apache version is 2.4
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15721 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15551] checked out items not showing on returns.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- I'm confused by this too. I agree that Bug 14821 seems like a regression, and I would love to see it turned into a preference. However, it doesn't have anything to do with showing what other items a patron has checked out, and that is not something Koha has ever done on the check-in page. If the issue has come up after updating to 3.20 then I suspect this is a communication issue and Bug 14821 is what is really being discussed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47575|0 |1 is obsolete| | --- Comment #27 from Marc Véron <veron(a)veron.ch> --- Created attachment 47587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47587&action=ed… Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47574|0 |1 is obsolete| | --- Comment #26 from Marc Véron <veron(a)veron.ch> --- Created attachment 47586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47586&action=ed… Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47573|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron(a)veron.ch> --- Created attachment 47585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47585&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47572|0 |1 is obsolete| | --- Comment #24 from Marc Véron <veron(a)veron.ch> --- Created attachment 47584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47584&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47571|0 |1 is obsolete| | --- Comment #23 from Marc Véron <veron(a)veron.ch> --- Created attachment 47583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47583&action=ed… Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47093|0 |1 is obsolete| | --- Comment #22 from Marc Véron <veron(a)veron.ch> --- Created attachment 47582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47582&action=ed… Bug 15632: Koha::Patron::Messages - Remove AddMessage The AddMessage subroutine just 1. checked if all the parameters were passed 2. inserted the message in the DB 3. logged the action if needed These 3 jobs are now done by the overloaded store method of Koha::Patron::Message. Test plan: 1/ Go on the "check out" page of a patron 2/ Add different new messages Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47092|0 |1 is obsolete| | --- Comment #21 from Marc Véron <veron(a)veron.ch> --- Created attachment 47581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47581&action=ed… Bug 15632: Koha::Patron::Messages - Be sure add and delete will log If the pref BorrowersLog is on, the store and delete method should log into the action_logs table. Easy to do by overloading them. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0