February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47091|0 |1 is obsolete| | --- Comment #20 from Marc Véron <veron(a)veron.ch> --- Created attachment 47580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47580&action=ed… Bug 15632: Koha::Patron::Messages - Add new classes The following 4 CRUD subroutines in C4::Members: - AddMessage - DeleteMessage - GetMessagesCount - GetMessages could be replaced with a new package based on Koha::Objets. This patchset will add the 2 Koha::Patron::Message[s] classes, then use it to replace the different calls to these subroutine. It will slightly reduce the size of C4::Members Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15415] Warn when creating new printer profile for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|gmcharlt(a)gmail.com |aleishaamohia(a)hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15415] Warn when creating new printer profile for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Aleisha, I am not sure to understand the point of this warning, but I would prefer to keep it. I think the problem comes from the script patroncards/edit-profile.pl: 93 $template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0; The get_attr method should not be called if we are adding a new profile. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15416] Warns on Guided Reports page
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Assignee|gmcharlt(a)gmail.com |aleishaamohia(a)hotmail.com Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15416] Warns on Guided Reports page
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47568|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47579&action=ed… Bug 15416: Warns on guided_reports.pl Initialising $phase variable to be '' if not defined. To test: 1) Go to Reports -> Guided Reports Wizard 2) Notice warns 3) Apply patch 4) Refresh page 5) Confirm warns are gone and page still works as it should Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Warns are gone. Page still works as expected Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended patch: -my $phase = $input->param('phase'); -$phase //= ''; +my $phase = $input->param('phase') // ''; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15416] Warns on Guided Reports page
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47549|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47576&action=ed… Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar This patch replaces the email address text overflow solution implemented by Bug 3256 with a CSS3 technique: text-overflow: ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow To test, apply the patch and clear your browser cache. Edit the primary email address of a patron so that it is very long. View that patron in the staff client (on the checkout or details page, for instance) and confirm that the email address is truncated with "..." Confirm that the link and the title attribute of the link contain the correct, full email address. Revision uses a percentage instead of a fixed width for email display in the sidebar to accommodate varying sidebar widths. Also added: Handling of all email addresses displayed on the patron detail page. Although email addresses in the body of that page were not in the scope of the original patch, it's a good improvement to include those as well. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #206 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Julian Maurice from comment #205) > I started packaging this module. > ITP bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813574 > Git repo: > https://anonscm.debian.org/cgit/pkg-perl/packages/libtemplate-stash- > autoescaping-perl.git/ Great! Thx -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15584] Staff client list errors are incorrectly styled
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- So, for instance: 1/ on admin/cities, delete one city, you will get an 'alert': "Are you sure you want to delete this stuff?" 2/ on admin/branches, delete one library, not linked to anything. You won't get an 'alert', but a 'fieldset' (fixme, not consistent). 3/ on admin/branches, delete one library linked to a patron. You will get an 'error' "This library cannot be deleted." 4/ on admin/branches, create a library with an existing branchcode. You will get an 'error' "An error occurred when adding this library. The branchcode might already exist." The last one is definitely an error, the patron has lost his form. And as I said previously, it should be caught when editing the form. 1/ and 2/ should have the same behavior (which one? we usually use 'alert') 3/ is between the 'alert' and the 'error', it's more an info actually. -- You are receiving this mail because: You are watching all bug changes.

1 0