February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15551] checked out items not showing on returns.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3144] anti-spam for opac-suggestions
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #32 from Marc Véron <veron(a)veron.ch> --- The self registration ( cgi-bin/koha/opac-memberentry.pl ) has already a text based captcha with a random string: "Please type the following characters into the preceding box: ODXZX" I think it would be good to re-use technique/code at all places where we have 'human user input'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #205 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #203) > Note that this still needs attention in terms of (Debian) packaging. > At first glance this module does not seem to be available in a Debian > package. I started packaging this module. ITP bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813574 Git repo: https://anonscm.debian.org/cgit/pkg-perl/packages/libtemplate-stash-autoesc… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47575&action=ed… Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47574&action=ed… Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47573&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47572&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessagesCount The GetMessageCount subroutine was only used once, in opac-user.pl, to know if some messages will be displayed. Test plan: 1/ Create messages to display at the OPAC for a patron 2/ Logged this patron in at the OPAC, you should see the messages displayed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47094|0 |1 is obsolete| | Attachment #47095|0 |1 is obsolete| | Attachment #47515|0 |1 is obsolete| | Attachment #47516|0 |1 is obsolete| | Attachment #47525|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47571&action=ed… Bug 15632: Koha::Patron::Messages - Remove DeleteMessage The DeleteMessage just deleted and logged if needed. This is now be done by Koha::Patron::Message->delete. Test plan: 1/ Go on the "check out" page of a patron 2/ Delete some messages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RFC: Allow to reserve first |Allow to reserve first |available item from a group |available item from a group |of titles |of titles -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] RFC: Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '16

03 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47498|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 47570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47570&action=ed… Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes.

1 0