March 2016 - Koha-bugs - lists.koha-community.org

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48619|0 |1 is obsolete| | --- Comment #26 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 48806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48806&action=ed… Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey <seanm(a)pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] publisher code and publication year not fetched in acq orders
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris(a)bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 I'm just a bot <gitbot(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot(a)bugs.koha-community. | |org --- Comment #8 from I'm just a bot <gitbot(a)bugs.koha-community.org> --- .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); error: patch failed: C4/AuthoritiesMarc.pm:1553 error: C4/AuthoritiesMarc.pm: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11122] publisher code and publication year not fetched in acq orders
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 I'm just a bot <gitbot(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #27 from I'm just a bot <gitbot(a)bugs.koha-community.org> --- fatal: previous rebase directory .git/rebase-apply still exists but mbox given. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48805&action=ed… Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15987] New: Acq module fails with undefined subroutine &main::GetCurrency
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Bug ID: 15987 Summary: Acq module fails with undefined subroutine &main::GetCurrency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: hector.hecaxmmx(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 15084 Acq module fails with undefined subroutine &main::GetCurrency Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #58 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #57) > Aarrggg > This was hard to find: > The foreign key constraint (in AQorder) will sometimes fail on you: > Why? > aqorder: > | currency | varchar(3) | YES | MUL | NULL | > currency: > | currency | varchar(10) | NO | PRI | | > > Length is not the SAME !! So I take it we need a dbrev to update aqorder.currency to varchar(10) as well? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14694] Make decreaseloanHighHolds more flexible
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #45 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48804&action=ed… Bug 14694 [QA Followup] - Update Koha::Borrower references to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
by bugzilla-daemon＠bugs.koha-community.org 08 Mar '16

08 Mar '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- You are correct Joubu, there are easier methods, patch to follow later -- You are receiving this mail because: You are watching all bug changes.

1 0