April 2016 - Koha-bugs - lists.koha-community.org

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #32 from David Cook <dcook(a)prosentient.com.au> --- I know I did a 180 on my support for this patch over time, but just adding a verbal/textual endorsement of this latest patch. It doesn't need it, as Marc has already signed it off, but a quick review of the code makes it look good. You never know when you need to add a different PQF attribute to the entire query. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13438] Convert normarc framework plugins to new style (see also 10480)
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thanks Magnus for testing. You discovered that prove does not like extra arguments. "Cannot detect source of '--incl'! at /usr/share/perl/5.14/TAP/Parser/IteratorFactory.pm line 263" Prove provides a way (I learned now too): It is possible to supply arguments to tests. To do so separate them from prove's own arguments with the arisdottle, '::'. For example prove -v t/mytest.t :: --url http://example.com Also note that the overwhelming number of uninitialized warnings was only hidden by disabling the warnings pragma. If you would only add "use warnings" in the plugins before this patch and run prove, you will see them all. So now we see those warnings, we should do something about them.. (I already have a report opened for that.) prove t/db_dependent/FrameworkPlugin.t :: --incl cataloguing/value_builder/normarc_*.pl t/db_dependent/FrameworkPlugin.t .. 1/5 [LOTs of uninitialized warnings] t/db_dependent/FrameworkPlugin.t .. ok All tests successful. Files=1, Tests=5, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.08 cusr 0.10 csys = 2.22 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1750] Report bor_issues_top erroneous and truncated results
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1750 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #12 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5979] Add separate OPACISBD system preference
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #42 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #34 from M. Tompsett <mtompset(a)hotmail.com> --- I've moved this back to assigned, since I only rebased it. The issue was .raw which was removed because the security patch which escaped all the data was removed. Also, 'new'? Can we try to have keys/fields which aren't reserved words? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #33 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 50558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50558 Bug 14272: Show single news item (backend) Review of attachment 50558: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=142…) ----------------------------------------------------------------- ::: C4/NewsChannels.pm @@ +195,4 @@ > =cut > > sub GetNewsToDisplay { > + my ($lang,$branch,$time,$id) = @_; Refactor to a hash as recommended by PERL 16. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_sho… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47673|0 |1 is obsolete| | --- Comment #32 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 50559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50559&action=ed… Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47672|0 |1 is obsolete| | --- Comment #31 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 50558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50558&action=ed… Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47671|0 |1 is obsolete| | --- Comment #30 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 50557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50557&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11129] Filtering Items based on type in opac-detail.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Patch doesn't apply |Failed QA --- Comment #9 from M. Tompsett <mtompset(a)hotmail.com> --- Not only doesn't this apply, this approach is completely wrong now. Please look into Koha/RecordProcessor.pm and see bug 11592 as an example of how to move forward with this. -- You are receiving this mail because: You are watching all bug changes.

1 0