April 2016 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #3 from M. Tompsett <mtompset(a)hotmail.com> --- This reminds me of bug 10589. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #31 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release! Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12787] Unit test files should be better organized
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #12 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release! Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42173|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50556&action=ed… Bug 14362: Regression tests This should trigger the error. Attempts to shift system time zones did not make sense as to the number of failures. Added Time::Fake dependency, if it isn't installed these extra tests don't run. There is a nice skip message about it. Added License text. TEST PLAN --------- 1) apply test patch 2) sudo dpkg-reconfigure tzdata -- set your system time to GMT (Africa/Abidjan) 3) prove t/Circulation/AgeRestrictionMarkers.t -- should not fail, even if you change system time to any time. 4) sudo dpkg-reconfigure tzdata -- set your timezone to Eastern 5) sudo date -s"2015-06-18 21:15:00" 6) date -- should be past 9pm Eastern timezone 7) prove t/Circulation/AgeRestrictionMarkers.t -- kaboom! 8) sudo date -s"2015-06-18 12:00:00" 9) date -- should be noon Eastern timezone 10) prove t/Circulation/AgeRestrictionMarkers.t -- success?! Time sensitive tests are bad tests. 11) sudo apt-get install libtime-fake-perl 12) prove t/Circulation/AgeRestrictionMarkers.t -- kaboom! -- changing timezone to anything other than GMT should trigger a kaboom. 13) apply fix patch 14) prove t/Circulation/AgeRestrictionMarkers.t -- should work all the time. 15) less t/Circulation/AgeRestrictionMarkers.t -- the license text should be similar to http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence 16) koha qa test tools. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42172|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50555&action=ed… Bug 14362: PEGI15 Circulation/AgeRestrictionMarkers test fails It is best to test when UTC date is a date in the future compared to your timezone. I'm in Eastern, so right now, I expect this test to fail for another 2.5 hours. TEST PLAN --------- 1) prove t/Circulation/AgeRestrictionMarkers.t -- fails for PEGI 15 after 9pm. 2) Apply patch 3) prove t/Circulation/AgeRestrictionMarkers.t -- works. 4) koha qa test tools Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50542|0 |1 is obsolete| | --- Comment #113 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50554&action=ed… Bug 11592: MARCView and ISBD followup There are still some leaks, but it is not as a result of the filter, but rather a result of poorly written template files. Bug fixing template files is beyond the scope of this set of patches. TEST PLAN --------- 1) Backup your DB 2) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=-8; -- this should set EVERYTHING to hidden across the board. 3) In staff client, set OPACXSLTDetailsDisplay to blank 4) In OPAC, view any detail. -- Normal view may mostly leak values still. -- MARC view may leak values. -- ISBD view may leak values. 5) In staff client, set OPACXSLTDetailsDisplay to default 6) In OPAC, view any detail. -- same issues as step 4 -- 'View Plain' may leak too. 7) 'Save record' -> 'Dublin Core' 8) Apply this patch 9) run koha qa test tools -- should be fine 10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t -- should pass -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too 11) In OPAC, view any detail. -- Normal view: -- Material type comes from the LEADER field. -- Lists this is on will still display -- 'Tags from this library' will still display -- Item information in table will still display (THIS IS BEYOND SCOPE) -- MARC view: -- Record number is leaked (THIS IS BEYOND SCOPE) -- 'View plain' leaks LEADER field. -- ISBD view may leak field headings, but not values. (THIS IS BEYOND SCOPE) 12) In staff client, set OPACXSLTDetailsDisplay to blank 13) In OPAC, view any detail. -- same kind of output as step 10 14) 'Save record' -> BIBTEXT -- Should be next to nothing leaked. 15) 'Save record' -> Dublin Core -- Should be the same or less leaked between the two versions. -- (XML FILTERING IS BEYOND SCOPE) 16) In the staff client, go view the same record. -- it should be mostly hidden in ISBD View. 17) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=1; -- this should set EVERYTHING to hidden in OPAC, but not the STAFF across the board. 18) Refresh the staff ISBD page -- values should reappear. 19) View the ISBD details in the OPAC -- values should still be hidden. 20) Check out the OPAC Cart and List -- while the intermediate pages may still leak the download links should leak very minimally. -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH THE INTRANET ISBD AND SOME CART/LIST STUFF WERE FIXED BECAUSE OF THE GetISBDView REFACTOR) Expectations: Before Patch - all the OPAC Detail pages will display things After Patch - all the OPAC Detail pages will display much less, and hopefully nothing (though there are known limits). the ISBD detail page in the Staff client will be filtered as well based on STAFF settings. The saving/exporting should generate nearly empty files. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49614|0 |1 is obsolete| | --- Comment #112 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50553&action=ed… Biblio tweak for MARCSUBJECT https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49613|0 |1 is obsolete| | --- Comment #111 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50552&action=ed… Applying filtering to opac interface. Applying the filtering and then... Debugging opac/opac-detail.pl filtering Debugging opac/opac-ISBDdetail.pl more Debugging opac/opac-export.pl Tweak opac/opac-export.pl fix variable declarations, conditional assignments Debugging opac/opac-showmarc.pl https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49612|0 |1 is obsolete| | --- Comment #110 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50551&action=ed… Bug 11592 - Add should_hide_marc method to filter Add should_hide_marc to ViewPolicy filter Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0