April 2016 - Koha-bugs - lists.koha-community.org

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48001|0 |1 is obsolete| | --- Comment #109 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 50550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50550&action=ed… Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat <robin(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15113] koha-rebuild-zebra should check USE_INDEXER_DAEMON and skip if enabled
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15113 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15263] XSLT display fetches sysprefs for every result processed
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15263 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50489|0 |1 is obsolete| | --- Comment #108 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 50542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50542&action=ed… Bug 11592: MARCView and ISBD followup There are still some leaks, but it is not as a result of the filter, but rather a result of poorly written template files. Bug fixing template files is beyond the scope of this set of patches. TEST PLAN --------- 1) Backup your DB 2) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=-8; -- this should set EVERYTHING to hidden across the board. 3) In staff client, set OPACXSLTDetailsDisplay to blank 4) In OPAC, view any detail. -- Normal view may mostly leak values still. -- MARC view may leak values. -- ISBD view may leak values. 5) In staff client, set OPACXSLTDetailsDisplay to default 6) In OPAC, view any detail. -- same issues as step 4 -- 'View Plain' may leak too. 7) 'Save record' -> 'Dublin Core' 8) Apply this patch 9) run koha qa test tools -- should be fine 10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t -- should pass -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too 11) In OPAC, view any detail. -- Normal view: -- Material type comes from the LEADER field. -- Lists this is on will still display -- 'Tags from this library' will still display -- Item information in table will still display (THIS IS BEYOND SCOPE) -- MARC view: -- Record number is leaked (THIS IS BEYOND SCOPE) -- 'View plain' leaks LEADER field. -- ISBD view may leak field headings, but not values. (THIS IS BEYOND SCOPE) 12) In staff client, set OPACXSLTDetailsDisplay to blank 13) In OPAC, view any detail. -- same kind of output as step 10 14) 'Save record' -> BIBTEXT -- Should be next to nothing leaked. 15) 'Save record' -> Dublin Core -- Should be the same or less leaked between the two versions. -- (XML FILTERING IS BEYOND SCOPE) 16) In the staff client, go view the same record. -- it should be mostly hidden in ISBD View. 17) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=1; -- this should set EVERYTHING to hidden in OPAC, but not the STAFF across the board. 18) Refresh the staff ISBD page -- values should reappear. 19) View the ISBD details in the OPAC -- values should still be hidden. 20) Check out the OPAC Cart and List -- while the intermediate pages may still leak the download links should leak very minimally. -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH THE INTRANET ISBD AND SOME CART/LIST STUFF WERE FIXED BECAUSE OF THE GetISBDView REFACTOR) Expectations: Before Patch - all the OPAC Detail pages will display things After Patch - all the OPAC Detail pages will display much less, and hopefully nothing (though there are known limits). the ISBD detail page in the Staff client will be filtered as well based on STAFF settings. The saving/exporting should generate nearly empty files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15923] New: Export records by id list impossible in export_records.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '16

22 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Bug ID: 15923 Summary: Export records by id list impossible in export_records.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Trying to use export_records.pl for exporting biblios by biblionumber (through list_id_file option) fails. It exports whole catalogue instead. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace(a)sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #107 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 50489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50489 Bug 11592: MARCView and ISBD followup Review of attachment 50489: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- ::: opac/opac-ISBDdetail.pl @@ +92,4 @@ > } > } > > +my $record_unfiltered = GetMarcBiblio($biblionumber,1); This is because GetMarcBiblio was previously called in C4::Biblio::GetISBDView with ,1 which includes embedded items. ::: opac/opac-MARCdetail.pl @@ +108,5 @@ > my ($bt_tag,$bt_subtag) = GetMarcFromKohaField('biblio.title',$itemtype); > $template->param( > bibliotitle => $biblio->{title}, > +) if $tagslib->{$bt_tag}->{$bt_subtag}->{hidden} <= 0 && # <=0 OPAC visible. > + $tagslib->{$bt_tag}->{$bt_subtag}->{hidden} > -8; # except -8; Forgot the -8 (flagged) case. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '16

21 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus(a)libriotech.no --- Comment #5 from Magnus Enger <magnus(a)libriotech.no> --- Just confirming the patches do not apply. Here is the error: $ git bz apply 14957 Bug 14957 - Write protecting MARC fields based on source of import 44056 - Bug 14957: Rule based permission for MARC fields 44057 - Bug 14957: Database changes 44058 - Bug 14957: Add filters to relevant scripts Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14957: Rule based permission for MARC fields Using index info to reconstruct a base tree... M C4/Biblio.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 14957: Rule based permission for MARC fields The copy of the patch that failed is found in: /home/magnus/scripts/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14957-Rule-based-permission-for-MARC-fields-IZUxzW.patch -- You are receiving this mail because: You are watching all bug changes.

1 0