April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15809] New: versions of CGI < 4.08 do not have multi_param
by bugzilla-daemon＠bugs.koha-community.org 02 Aug '16

02 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15809 Bug ID: 15809 Summary: versions of CGI < 4.08 do not have multi_param Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On debian Jessie, the CGI version is >= 4.08 Since this version, the param method raise a warning "CGI::param called in list context". Indeed, it can cause vulnerability if called in list context https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named… http://blog.gerv.net/2014/10/new-class-of-vulnerability-in-perl-web-applica… There is a long journey to get rid of these warnings. First I suggest to redefine the multi_param method when the CGI version installed is < 4.08, it will allow us to move the wrong ->param calls to ->multi_param without waiting for everybody to upgrade. The different ways to call these 2 methods are: my $foo = $cgi->param('foo'); # OK my @foo = $cgi->param('foo'); # NOK, will raise the warning my @foo = $cgi->multi_param('foo'); #OK $template->param( foo => $cgi->param('foo') ); # NOK, will raise the warning and vulnerable $template->param( foo => scalar $cgi->param('foo') ); # OK -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 15853] New: Add author and link columns to opac course reserves table
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15853 Bug ID: 15853 Summary: Add author and link columns to opac course reserves table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To be done: 1 - Add an author column to the opac course reserves table 2 - Add a 'link' column to the opac course reserves table, populated from the 856$u field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 16324] New: Move item search into header
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16324 Bug ID: 16324 Summary: Move item search into header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Item search is rarely used because it is difficult to find. If it was as easy to find as the advanced search it would probably be used more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 16008] New: noisy "fatal" warning when new file is moved in another patch
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Bug ID: 16008 Summary: noisy "fatal" warning when new file is moved in another patch Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com While working on Bug 15870, koha qa test tools gave this error fatal: ambiguous argument 't/db_dependent/RecordProcessor_ViewPolicy.t': unknown revision or path not in the working tree. This is in part, because a test file was moved/renamed and the files changed list includes the old filename. Gracefully handle the file no longer existing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 15824] New: 'Done' button is unclear on batch item modification and deletion
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Bug ID: 15759 Summary: Allow Koha::Object derived objects to be used as hashrefs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16166] New: Improve L1 cache performance
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Bug ID: 16166 Summary: Improve L1 cache performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org Bug 16044 introduced two-level caching mechanism to Koha::Cache. By default, get_from_cache() returns a deep copy of the data structures stored in L1 cache (aka "safe mode"). For extremely big and/or complex data structures (like MARC framework hash-of-hashes-of-hashes returned by GetMarcStructure() ), deep-cloning is currently very sub-optimal (i.e., 2-3x slower after Bug 16044); this patch addresses that particular issue. See also: Bug 16044 comments #18 - #23 -- You are receiving this mail because: You are watching all bug changes.

1 43

[Bug 16076] New: DBIx searches - performance issues
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 Bug ID: 16076 Summary: DBIx searches - performance issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org While testing Bug 11998 and Bug 15341, I did some quick & dirty comparisons on DBI vs DBIx search performace - how long does it take to fetch from the database: one small system preference (marcflavour) and all system preferences (545 rows). Results: 1) one syspref, DBI: 130 microseconds ( using 'SELECT value FROM systempreferences WHERE variable = ? LIMIT 1') 2) one syspref, DBIx: 1.25 miliseconds ( Koha::Config::SysPrefs->find($var)->value() ) 3) all preferences, DBI: 1.8 miliseconds ( 'SELECT variable, value FROM systempreferences' ) 4) all preferences, DBIx: 21 miliseconds ( Koha::Config::SysPrefs->search()->unblessed(), like in Bug 15341) If I use my $all_prefs_rs = Koha::Config::SysPrefs->search( undef, { columns => [qw/value variable/] } )->unblessed(); in 4), search is a bit quicker (17.1 ms). Maybe it can be improved somehow further, but I don't know how - any ideas? Those numbers may look not very significant at the first glanace, but remember that it's not uncommon for the Koha script to make 2000+ DBI calls (in such cases, they are usually very repetitive - small stuff fetched from uncomplicated tables, over and over again). -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 16278] New: Export.pl Tool needs select all/unselect all boxes for Library section
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '16

05 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16278 Bug ID: 16278 Summary: Export.pl Tool needs select all/unselect all boxes for Library section Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: hbraum(a)nekls.org QA Contact: testopia(a)bugs.koha-community.org The export.pl tool needs select all and unselect all boxes for the Library section. Right now, if you're only wanting a certain library's records exported, you have to unchecked lots of boxes (if you're in a multi-branch system). For us, that's 51 boxes to uncheck. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 16127] New: Add discharge menu item to patron toolbar
by bugzilla-daemon＠bugs.koha-community.org 01 Jul '16

01 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Bug ID: 16127 Summary: Add discharge menu item to patron toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The patron discharge feature added a "Discharge" tab in the left-hand sidebar menu. I think if we follow views vs. actions guideline (https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions) the link in the sidebar should say "Discharges" (as in view the patron's list of discharges) and there should be menu item in the toolbar (members-toolbar.inc) for the action of discharging the patron. I think this should be added to the "More" drop-down menu. -- You are receiving this mail because: You are watching all bug changes.

1 9