April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Patch complexity|--- |Small patch Status|Signed Off |Passed QA --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Code looks good to me. No errors from qa tools. Holds tests pass (Holds.t reports two errors before this patch already.) Still I am passing QA on this patch with some hesitation. I have no good reason to block this patch, especially since not touching the circulation rules will not change behavior. Hesitation is based on: [1] Simple test plan. We have so many prefs hooking into reserves/holds. How do we make sure that everything still works? (Tests pass..) [2] opac-reserve offers pickup locations that will (or may) not allow a hold to be filled. Should we offer them in the first place in such cases? [3] Rules form: Hold pickup library match is rather cryptic. The text above the rules should be made more clear (it pertains to Hold policy only). The new field could use some text and additional documentation (online help). Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14622] Add fr-CA data folder in the web installer
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48378|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 50904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50904&action=ed… [SIGNED-OFF] Bug 14622 - New data in French Canadian for the web installer. Add "fr-CA" folder. TEST PLAN : - install Koha - choose fr-CA as the installation language - check every options in the web installer - every file should load smoothly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Works well, no problem/warning loading all sample files. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14622] Add fr-CA data folder in the web installer
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50838|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 50903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50903&action=ed… Bug 15532 [QA Followup] - Remove unused variable Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50358|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 50902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50902&action=ed… Bug 15532 [QA Followup] - Remove unecessary lines from unit test Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49225|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 50901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50901&action=ed… Bug 15532: Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold Some libraries would like to be able to limit hold filling to items that match the pickup library for a hold based on the item's home or holding library. The patron's home library should not affect whether a patron can place the hold, instead the hold will only be fillable when an item matching the pickup location becomes available. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note the new "Hold pickup library match" rules for "checkout, hold, and return policy" and for "holds policy by item type" 4) Set the policy to "item's holding library" 5) Place a hold where the item's holding branch does not match the pickup branch 6) Check in the item 7) Note it is not trapped for the hold 8) Update the item's holding branch to match the pickup branch 8) Check in the item 9) Note the item is trapped for the hold 10) Repeat steps 4-9 but for home branch instead Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as described Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Signed Off |Passed QA --- Comment #25 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It looks like Statistics.pm is severely... untested. I couldn't spot unit tests for it :( I think this here works nicely and given the pending deadline I am ready to pass it - with the condition that a bug is opened to add a bit of test coverage. Deal? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50900&action=ed… [PASSED QA] Bug 12721: (followup) Replace mysqlism by DBIx::Class This patch removes the mysqlism (see comment #18) Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Fixed QA tools complaints about missing lines before and after =cut in POD. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50899&action=ed… [PASSED QA] Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields To reproduce issue: See comment #1 To test: - Apply patch - Leave syspref StatisticsFields empty - Display statistics for an author => Result: Table displays Shelving location, Collection code, Item type (as before) - Change syspref to any combination of location|itype|ccode => Result: Table displays columns as appropriate - Change syspref to some garbage => Result: Same as with empty syspref (was crashing without patch) - Change syspref to valid combination with trailing | => Result: Table displays columns as appropriate (was crashing without patch) - Change syspref to a combination of valid and invalid fields (location|blah|ccode) => Result: Table displays column of valid fields only (was crashing without patch) Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50897|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50898&action=ed… [PASSED QA] Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences This patch adds a warning to the about page if the syspref 'StatisticsFields' is misconfigured. Additionally, the text on Home > Administration > SystemPreferences for 'Statistics Fields' is changed. To test: - Apply patch - Edit syspref 'StatisticsFields'. Verify that the explanation makes sense. - Leave field empty => verify that no message appears on About page, tab System information - Insert valid field names, e.g. location|itype => verify that no message appears on the About page - Add trailing char => verify that the warning message appears on the About page - Fill in some garbage or misspell a field name => verify that the warning message appears on the About page Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0