April 2016 - Koha-bugs - lists.koha-community.org

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment on attachment 50743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50743 Bug 15581: Display the latest auto renew date possible when renewing manually Review of attachment 50743: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +3191,5 @@ > + > +=cut > + > +sub GetLatestAutoRenewDate { > + my ( $borrowernumber, $itemnumber ) = @_; You already have the issue, item and patron data where this code is called, why not pass them in? @@ +3195,5 @@ > + my ( $borrowernumber, $itemnumber ) = @_; > + > + my $dbh = C4::Context->dbh; > + > + my $item = GetItem($itemnumber) or return; Re-fetching item we already have. @@ +3196,5 @@ > + > + my $dbh = C4::Context->dbh; > + > + my $item = GetItem($itemnumber) or return; > + my $itemissue = GetItemIssue($itemnumber) or return; Re-fetching issue we already have. @@ +3199,5 @@ > + my $item = GetItem($itemnumber) or return; > + my $itemissue = GetItemIssue($itemnumber) or return; > + > + $borrowernumber ||= $itemissue->{borrowernumber}; > + my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ) Re-fetching patron data we already have. ::: circ/renew.pl @@ +83,5 @@ > ); > } > + if ( $error && ( $error eq 'auto_too_late' ) ) { > + $latest_auto_renew_date = C4::Circulation::GetLatestAutoRenewDate( > + $borrower->borrowernumber(), We should pass in the issue, item, and patron objects here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50907&action=ed… [PASSED QA] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) This patch re-indents the new include file because it's not often you get to help a new file come into the world, it should be indented nicely. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50906&action=ed… [PASSED QA] Bug 10171: Add a search box include on advanced search and item search pages This patch creates a new file: adv-search.inc. This search include has no catalog search (as it makes no sense to have the catalog search tab on the advanced search page). The item search page uses home-search.inc (with catalog search) as the catalog search is different to the item search. To test: 1) Go to Search (advanced search) 2) Confirm search header is there with no catalog search tab and works as expected 3) Go to item search 4) Confirm search header is there with catalog search tab and works as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Tested together with follow up patch, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've tested this on top of bug 16363 to see how they work together. No conflicts and works nicely! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11088] Patron entry page should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- I think this looks like a good solution. I think we should rename the id something more specific, like "#floating_save" to avoid id duplication in case we want to use this on other pages. Now we need to think about how this fits into rules for how to design interfaces like this. When to use a floating toolbar and when to use a floating save "panel?" I'd like to have a better guideline than "we use the panel when the toolbar doesn't work." One possible way of thinking about it: The floating save panel is used when there are no other controls which need to be displayed in a toolbar. Arlsan do you want to submit a follow-up patch with your change? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #33) > It looks like we have a 'ton' of timestamp in the database. Apart from that > there seems to be no existing other schema for timestamps columns that I > could spot. I am not opposed to changing it - I think that's what Marcel > wanted to do? This patch cannot go further in this form. So better move it to In discussion :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #26 from Marc Véron <veron(a)veron.ch> --- (In reply to Katrin Fischer from comment #25) > It looks like Statistics.pm is severely... untested. I couldn't spot unit > tests for it :( > > I think this here works nicely and given the pending deadline I am ready to > pass it - with the condition that a bug is opened to add a bit of test > coverage. Deal? See Bug 16379 :-) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16379 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16379 [Bug 16379] Add tests for Statistics.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15532] Add ability to allow only items whose home/holding branch matches the hold's pickup branch to fill a given hold
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15532 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

1 0