April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 --- Comment #44 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50918&action=ed… Bug 15126: Update dependencies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49846|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50917&action=ed… Bug 15126: x-mojo-controller deprecation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49845|0 |1 is obsolete| | CC| |kyle(a)bywatersolutions.com --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50916&action=ed… Bug 15126: Refactor spec file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Signed Off |In Discussion --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I think there are some questions that need to be answered before this can move along: 1) Should this be a blanket setting? Maybe the parent of an 8 year old would want this, but not the parent of a 17 year old 2) Should the generation of the notice be based on the guarantees messaging settings, or the guarantors? 3) Following 2, perhaps guarantors should have the option of receiving notices of guarantees as part of the messaging preferences 4) Wouldn't it be prudent to send the notice to both? It could just CC the guarantor I think at a minimum this should be an option for each guarantor, and the email should just add them as a CC ( or some other method so that both the guarantee and guarantor receive the notice ). A default setting of on or off could be added to the patron types editor, and a checkbox for receiving guarantees notices could be added to the messaging settings for guarantors on the staff side and the opac. What do you think of this? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I was also looking into this and have another note: Please take a look in Overdues.pm at how items.fine is formatted: $item->{'fine'} = currency_format($currency_format, "$fine", FMT_SYMBOL); # if active currency isn't correct ISO code fallback to sprintf $item->{'fine'} = sprintf('%.2f', $fine) unless $item->{'fine'}; I think we should use the same formatting for all money amounts if possible - especially as it's very likely that people will want to use those 2 together! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12267] Allow password option in Patron Attribute non functional
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16377 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16377 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16377 [Bug 16377] Fix t/db_dependent/Members/Attributes.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |kyle(a)bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle(a)bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Please add a unit test for this addition. Also, could you please change the key needed from borrowers.totalfine to something like borrowers.account_balance? I think that would be much more readable and explanatory. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15543] Use another notice in membership_expiry.pl
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50459|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50914&action=ed… Bug 15543: Use another notice in membership_expiry.pl This patch adds a letter parameter to the cron job membership_expiry. It is used to substitute the default notice by another one. This could be handy if you e.g. send a reminder after the first notice. In any case, it allows for more flexibility. Apart from this new parameter, this patch removes the sub parse_letter from the code. The call to GetPreparedLetter is moved to the for loop and the call to getletter is removed (no longer needed). If there is no letter found, the Letter module already warns you. So we just exit the loop. Test plan: [1] Run membership_expiry.pl -c -n -v -let NOT_EXIST Check if you see a warning (coming from Letters.pm) [2] Check if you have some soon expiring patrons or add before/after parameter to include some. Run membership_expiry.pl -c -n -v [-before ?] [-after ?] [3] Create a new notice MEMBERSHIP2. Copy the text from the original notice and make some adjustments. [4] Run membership_expiry.pl -c -v -let MEMBERSHIP2 [-before ?] [-after ?]. Be aware that this call generates email messages. Verify that the email contained the adjusted text. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> On top of Bug 14834 Work as described, tested using '-n' to see messages on terminal, e.g. membership_expiry.pl -v -n -c -before 3 -branch BC -after 2 --letter MEMEXP2 No errors Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0