April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15543] Use another notice in membership_expiry.pl
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15543 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50458|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50912&action=ed… Bug 14834: Make membership_expiry cronjob more flexible This patch adds three parameters to the cron job: -before and -after, and -branch. You can run the cronjob now in an adjusted frequency: say once a week with before 6 or after 6 (not both together). If your pref is set to 14, running before=6 will include expiries from 8 days to 14 days ahead. When you use after=6, you would include 14 days to 20 days ahead, etc. You could also rerun the job of yesterday by setting before=1 and after=-1; this could help in case of problem recovery. Obviously, the branch parameter can be used as a filter. NOTE: Why are these parameters passed only via the command line? Well, obviously the branch parameter is not suitable for a pref. The before/after parameter allows you to handle expiry mails different from the normal scheme or could be used in some sort of recovery. In those cases it will be more practical to use a command line parameter than editing a pref. NOTE: The unit test has been adjusted for the above reasons, but I also added some lines to let existing expires not interfere with the added borrowers by an additional count and using the branchcode parameter. Test plan: [1] Run the adjusted unit test GetUpcomingMembershipExpires.t [2] Set the expiry date for patron A to now+16 (with pref 14). Set the expiry date for patron B to now+11. [3] Run the cronjob without range. You should not see A and B. [4] Run the cronjob with before 3. You should see patron B. [5] Run the cronjob with before 3 and after 2. You should see A and B. [6] Repeat step 5 with a branchcode that does not exist. No patrons. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Work as described following test plan. Test pass No errors New parameters work with one (-) or two(--) dashes, no problem with that but convention suggest that 'long' options use two-dashes. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14834] Make membership_expiry cronjob more flexible
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14834 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13961] Option to include patron's total amount of fines in notices
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Testing this on top of bug 16378 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50909&action=ed… Bug 15564 - Fix tranfert branch: Set collection branch with return branch if it is empty. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50120|0 |1 is obsolete| | Attachment #50121|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50908&action=ed… Bug 15564 - Display "print slip" option when returning an item which is in a rotating collection To Test - 1. Make a new rotating collection (under tools) with at least one book in it. 2. Check out the book/s from rotating collection. 3. Set library to a different library. 4. Check in book you just checked out. 5. Should show a dialog box with no print slip link or city. 6. Apply patch and repeat steps 1-4. Dialog box should now show the item name, city name and print slip link. Patch works as expected. (Superfluous white space removed on line 136) Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15564] Display "print slip" option when returning an item which is in a rotating collection
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15564 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle(a)bywatersolutions.com --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Would you please update the code to pass the object instead of the keys? It makes sense to avoid fetching all this data multiple times when there is no need to do so. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0