May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #41 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- > > Sorry, forgot to apply the last patch locally. Forgot to sing also :) I've signed yours, can't sign mine. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51672|0 |1 is obsolete| | --- Comment #40 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 51680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51680&action=ed… [SIGNED-OFF] Bug 13669: Catch the errors to have them to the logs This patch redirect STDERR to a variable to retrieve the errors raised by the DBMS when loading a sql file, it could be useful to debug errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> It's better of course, trying to load a failed fiel it outputs mysl errors DBD::mysql::st execute failed: You have an error in your SQL syntax... No errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12641] Formally deprecate the GRS-1 indexing mode
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506 [Bug 16506] rebuild_zebra.pl still using USMARC as default -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51672&action=ed… Bug 13669: Catch the errors to have them to the logs This patch redirect STDERR to a variable to retrieve the errors raised by the DBMS when loading a sql file, it could be useful to debug errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #37) > Without the patch the errors are log into the Koha log file and there is not > crash > With the patch, there is nothing in the log file and Koha crashes. Sorry, forgot to apply the last patch locally. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 21 May '16

21 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Yes, I agree: fix without change in the behavior. That's why I think we should update the patch :) Without the patch the errors are log into the Koha log file and there is not crash With the patch, there is nothing in the log file and Koha crashes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Tomás Cohen Arazi from comment #35) > (In reply to Jonathan Druart from comment #34) > > I don't know if we should fail or continue actually, hard to say. > > I would say we should block anything if an error occurs (and so do not > > execute next files). > > Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use. > > Any behaviour change in that way would be a nice improvement, but it would > need to be discussed. Also, that would be an enhancement. > This is a blocker bugfix so Koha works on newer operating systems, with > backwards compatibility. Keeping the current behaviour, making it work. I > think we should push it if the Packaging manager agrees to package > DBIx::RunSQL (it only depends on DBI!) and add it to the repository. Was about to say something similar. Also 'force' seems to hide the problems, just tried it and can't get number of problems. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #35 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #34) > I don't know if we should fail or continue actually, hard to say. > I would say we should block anything if an error occurs (and so do not > execute next files). > Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use. Any behaviour change in that way would be a nice improvement, but it would need to be discussed. Also, that would be an enhancement. This is a blocker bugfix so Koha works on newer operating systems, with backwards compatibility. Keeping the current behaviour, making it work. I think we should push it if the Packaging manager agrees to package DBIx::RunSQL (it only depends on DBI!) and add it to the repository. -- You are receiving this mail because: You are watching all bug changes.

1 0