May 2016 - Koha-bugs - lists.koha-community.org

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #4) > > 4 - Search combined with other terms, results should be returned as > > expected > Is that how it's supposed to work or do I misunderstand this step? Fixed it, I wasn't resetting the fields type after hitting a date -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51505|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 51654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51654&action=ed… Bug 14874 - (followup) Refactor t/db_dependent/Utils/Datatables_Members.t to use TestBuilder To test: 1 - Apply other patches (not this one) 2 - Prove t/db_dependent/Utils/Datatables_Members.t 3 - SHould pass 4 - Apply this patch 5 - prove t/db_dependent/Utils/Datatables_Members.t 6 - All tests should continue to pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51652|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 51653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51653&action=ed… Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches This patch alters C4::Utils::DataTables::Members::search to autodetect if the searchmember parameter is a date and search by DOB if so To test: 1 - Apply patch 2 - Search for members by DOB formatted as per dateformat syspref or mysql format 3 - Results should be returned as expected 4 - Search combined with other terms, results should be returned as expected 5 - Search for patrons without using dates, results should be as expected 6 - Search using search fields 'Date of birth' from expanded menu on patron search - results should be returned as before (Note dying on incorrect format is an existing bug) 7 - prove t/db_dependent/Utils/Datatables_Members.t Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51504|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 51652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51652&action=ed… Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches This patch alters C4::Utils::DataTables::Members::search to autodetect if the searchmember parameter is a date and search by DOB if so To test: 1 - Apply patch 2 - Search for members by DOB formatted as per dateformat syspref or mysql format 3 - Results should be returned as expected 4 - Search combined with other terms, results should be returned as expected 5 - Search for patrons without using dates, results should be as expected 6 - Search using search fields 'Date of birth' from expanded menu on patron search - results should be returned as before (Note dying on incorrect format is an existing bug) 7 - prove t/db_dependent/Utils/Datatables_Members.t Sponsored by Carnegie Stout Library (https://www.dubuque.lib.ia.us/) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud(a)biblibre.com Status|Signed Off |Needs Signoff --- Comment #62 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Patches rebased on master + Adds renaming of the column gstrate in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #61 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51649&action=ed… Bug 13321: Adds renaming of gstrate column in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51085|0 |1 is obsolete| | --- Comment #60 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51648&action=ed… Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51084|0 |1 is obsolete| | --- Comment #59 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51647&action=ed… Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51083|0 |1 is obsolete| | --- Comment #58 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51646&action=ed… Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0