May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I think we should gracefully handle errors, as it was before. If C4::Installer::load_file encounters an error, Koha will crash. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51663&action=ed… Bug 9543: Separate MTT with commas Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51662&action=ed… Bug 9543 - (Follow-up) Show patrons messaging subscription on holds notification As of comment #19 - Code de-duplicated to a BLOCK statement - Variable renamed - Wording slightly changed. I like it that way, but feel free to change it in a follow-up Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51661&action=ed… Bug 9543 - Show patrons messaging subscription on holds notification not already waiting Same plan as previous patch, but this one should show the message for a hold not already waiting but not requiring a transfer (hold-found2 alert box) Signed-off-by: Chris Kirby <christopherlawrencekirby(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51515|0 |1 is obsolete| | Attachment #51516|0 |1 is obsolete| | Attachment #51641|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51660&action=ed… Bug 9543 - Show patrons messaging subscription on holds notification Display an information about a patron's messaging preferences if an item is checked in where the patron has put a hold. To test: - Apply patch - Make sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value) - Place a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verify that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Chris Kirby <christopherlawrencekirby(a)gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #23 from Marc Véron <veron(a)veron.ch> --- (In reply to Jonathan Druart from comment #22) > Thanks Marc. > What about > [%~ UNLESS loop.last %], [% ELSE %].[% END ~%] > To separate the mtt with a comma and end them with a dot? > I can provide a follow-up if you think it's better. Hi Jonathan, that would be nicer indeed, and yes please for the follow up :-) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Thanks Marc. What about [%~ UNLESS loop.last %], [% ELSE %].[% END ~%] To separate the mtt with a comma and end them with a dot? I can provide a follow-up if you think it's better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14571] using_https check for ssl connections doesn't work in some situations
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Oliver Bock from comment #20) > Created attachment 51640 [details] [review] > Use SSL when querying Open Library API > > FWIW, here's a patch to use SSL for Open Library as well... Would you please open a new bug report (and link it to this one) to attach your patch? This one is marked as "pushed to master" and new patches should go on their own bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0