May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I don't know if we should fail or continue actually, hard to say. I would say we should block anything if an error occurs (and so do not execute next files). Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10904] Limit patron modification request management by branch
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16555 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12834] patron category with a category type written with an accent can't be deleted
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12834 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Is it still valid? It seems that it's not possible (anymore?) to define a patron category with a category code containing "é". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Jonathan Druart from comment #31) > I think we should gracefully handle errors, as it was before. > If C4::Installer::load_file encounters an error, Koha will crash. You are right, added a possible fix. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13669] Web installer fails to load sample data on MySQL 5.6+
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 51671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51671&action=ed… Bug 13669: Re-adds error handling to load_sql This patch prevents crashing in case an error is detected when loading a file To test: 1) Apply patch 2) Mangle kohastructure.sql or any sample file adding and invalid SQL line 3) Run webinstaller and check that the error is handled gracefully -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #112 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Before pushing this, it could be great to execute the update DB entry on a large DB, which has been updated from several Koha versions. Does anyone have that on hand? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #111 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #110) > What about (really) deleted items? > The ones which is not in items or deleteditems table? > The update DB entry will raise the warning, but not sure it's relevant. Forget that, again. But what about deleted items, the ones in the deleteditems table? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #110 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What about (really) deleted items? The ones which is not in items or deleteditems table? The update DB entry will raise the warning, but not sure it's relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #109 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #108) > (In reply to Jonathan Druart from comment #107) > > (In reply to Tomás Cohen Arazi from comment #106) > > > I'm abandoning this bug. It went too far. > > > > C'mon!!! :) > > > > Question 1 on comment 102 was > > > > > C4/Circulation.pm > > > 1868 my $biblio = $item_level_itypes ? undef : GetBiblioData( $item->{ > > > biblionumber } ); # don't get bib data unless we need it > > > > > > Should not we use GetBiblioItemByBiblioNumber instead to avoid 2 left joins > > > per return? > > > > If you think I am right, I can provide a patch for that. > > You are right :-D Forget that, GetBiblioItemByBiblioNumber has a weird return. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14888] Move the cities related code to Koha::Cities
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 [Bug 16001] Use standard message dialog when there are no cities to list -- You are receiving this mail because: You are watching all bug changes.

1 0