May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51082|0 |1 is obsolete| | --- Comment #57 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51645&action=ed… Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51081|0 |1 is obsolete| | --- Comment #56 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51644&action=ed… Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51080|0 |1 is obsolete| | --- Comment #55 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 51643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51643&action=ed… Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Marc Véron <veron(a)veron.ch> --- Not sure if it can be switched back to signed-off or if it needs an other sign-off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #20 from Marc Véron <veron(a)veron.ch> --- Created attachment 51641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51641&action=ed… Bug 9543 - (Follow-up) Show patrons messaging subscription on holds notification As of comment #19 - Code de-duplicated to a BLOCK statement - Variable renamed - Wording slightly changed. I like it that way, but feel free to change it in a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14571] using_https check for ssl connections doesn't work in some situations
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571 --- Comment #20 from oliver.bock(a)aei.mpg.de --- Created attachment 51640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51640&action=ed… Use SSL when querying Open Library API FWIW, here's a patch to use SSL for Open Library as well... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15333] Use Koha::Cache for caching all holidays
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15333] Use Koha::Cache for caching all holidays
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 51638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51638&action=ed… Bug 15333: [QA Follow-up] Add few tests This report had no test plan and no unit tests. Adding some lines to Holidays.t. Added a trivial line move in Calendar.pm. Test plan: Run t/db_dependent/Holidays.t with and without cache. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested with memcached, Cache::Memory and no cache (edit Cache.pm). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15333] Use Koha::Cache for caching all holidays
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51223|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 51637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51637&action=ed… Bug 15333: Use Koha::Cache to cache exception_holidays instead of a package variable On the same way as bug 14522, we should use Koha::Cache to cache exception_holidays. It's not safe to use a package variable if running under Plack. There is not test plan, just make sure the changes make sense. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15333] Use Koha::Cache for caching all holidays
by bugzilla-daemon＠bugs.koha-community.org 20 May '16

20 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15333 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0