May 2016 - Koha-bugs - lists.koha-community.org

[Bug 16489] New: ES code incorrectly refers to Moose
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 Bug ID: 16489 Summary: ES code incorrectly refers to Moose Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce: - Run: $ git grep Moose => FAIL: There are unneeded references to Moose: Koha/SearchEngine/Zebra/QueryBuilder.pm:use Moose::Role; Koha/SearchEngine/Zebra/Search.pm:#use Moose::Role; -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16453] New: t/db_dependent/Koha_ElasticSearch_Indexer.t should use koha-conf.xml information
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16453 Bug ID: 16453 Summary: t/db_dependent/Koha_ElasticSearch_Indexer.t should use koha-conf.xml information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: gmcharlt(a)gmail.com t/db_dependent/Koha_ElasticSearch_Indexer.t currently has hardcoded information about the ES server it needs to use. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 16451] New: Fix missisng body id in orders_by_budget.tt
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16451 Bug ID: 16451 Summary: Fix missisng body id in orders_by_budget.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce: - Run: $ prove xt/tt_valid.t => FAIL: Tests fail on orders_by_budget.tt -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16448] New: Perlcritic errors introduced by 12478
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16448 Bug ID: 16448 Summary: Perlcritic errors introduced by 12478 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/00-testcritic.t t/00-testcritic.t .. 113/728 # Failed test 'Test::Perl::Critic for "catalogue/search.pl"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "catalogue/search.pl": # "@results" is declared but not used at line 475, column 1. Unused variables clutter code and make it harder to read. (Severity: 3) t/00-testcritic.t .. 262/728 # Failed test 'Test::Perl::Critic for "Koha/Authority.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 110. # # Perl::Critic found these violations in "Koha/Authority.pm": # "return" statement with explicit "undef" at line 67, column 9. See page 199 of PBP. (Severity: 5) t/00-testcritic.t .. 723/728 # Looks like you failed 2 tests of 728. t/00-testcritic.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/728 subtests Test Summary Report ------------------- t/00-testcritic.t (Wstat: 512 Tests: 728 Failed: 2) Failed tests: 114, 265 Non-zero exit status: 2 Files=1, Tests=728, 139 wallclock secs ( 0.20 usr 0.01 sys + 127.21 cusr 10.62 csys = 138.04 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 16447] New: "Borrow Permission" should not be used anymore
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447 Bug ID: 16447 Summary: "Borrow Permission" should not be used anymore Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 7976 has removed this permission, but other patches re-added it... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 16445] New: Bug 12478 has added an unnecessary line to Koha/Database.pm
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16445 Bug ID: 16445 Summary: Bug 12478 has added an unnecessary line to Koha/Database.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 12478 >From commit 95dabf4bfd15f6aed149c17546c00083063a01c1 Bug 12478 - add some base objects that the ES code will depend on +our $schema; # the schema is a singleton This is not needed Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16419] New: Tests of t/db_dependent/Acquisition.t do not pass
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16419 Bug ID: 16419 Summary: Tests of t/db_dependent/Acquisition.t do not pass Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 11371 The tests added by bug 11371 have been put after the rollback statement. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 [Bug 11371] Add a new report : Orders by budget -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 16414] New: aqorders.budgetgroup_id has never been used and can be removed
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16414 Bug ID: 16414 Summary: aqorders.budgetgroup_id has never been used and can be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16405] New: Fix Circulation/NoIssuesChargeGuarantees.t test 2
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 Bug ID: 16405 Summary: Fix Circulation/NoIssuesChargeGuarantees.t test 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com Resolve: # Failed test 'Patron cannot check out item due to debt for guarantee' # at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 63. # got: '10' # expected: '10.00' -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16404] New: Fix Circulation/Branch.t (tests 8-11)
by bugzilla-daemon＠bugs.koha-community.org 16 May '16

16 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 Bug ID: 16404 Summary: Fix Circulation/Branch.t (tests 8-11) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com Resolve: # Failed test 'GetBranchitem returns holdallowed and return branch' # at t/db_dependent/Circulation/Branch.t line 226. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'Without parameters GetBranchItemRule returns the values in default_circ_rules' # at t/db_dependent/Circulation/Branch.t line 234. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules' # at t/db_dependent/Circulation/Branch.t line 239. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist # Failed test 'With only one parametern GetBranchItemRule returns default values' # at t/db_dependent/Circulation/Branch.t line 244. # Structures begin differing at: # $got->{hold_fulfillment_policy} = 'any' # $expected->{hold_fulfillment_policy} = Does not exist t/db_dependent/Circulation/Branch.t .. 13/14 # Looks like you failed 4 tests of 14. t/db_dependent/Circulation/Branch.t .. Dubious, test returned 4 (wstat 1024, 0x400) -- You are receiving this mail because: You are watching all bug changes.

1 10