July 2016 - Koha-bugs - lists.koha-community.org

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53402|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz(a)catalyst.net.nz> --- Created attachment 53465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53465&action=ed… [SIGNED-OFF] Bug 14876 - Show number of holds on the staff side next to 'holds' link This patch adds a a Holds plugin for the templates to count existing holds on a record. We then use this in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt to display the current number of holds on a record. To test: 1 - Search in staff 2 - Note holds link has no extra information 3 - Apply patch 4 - prove -v t/db_dependent/Template/Plugin/Holds.t 5 - Do search in staff that returns records with some holds (i.e. place some holds) 6 - Note the number of holds now displays next to the text of the link: Holds (#) Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52899|0 |1 is obsolete| | Attachment #52900|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz(a)catalyst.net.nz> --- Created attachment 53464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53464&action=ed… [SIGNED-OFF] Bug 15023: (followup) Remove warnings By setting 'use Modern::Perl' some previously hidden warnings arised. This patch removes them by testing the variable $balance for undef before using it in a comparisson. Sponsored-by: VOKAL Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15023] Allow patron anonymize/ bulk delete tool to be limited by branch
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 --- Comment #3 from Liz Rea <liz(a)catalyst.net.nz> --- Created attachment 53463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53463&action=ed… [SIGNED-OFF] Bug 15023: Allow patron anonymize/bulk delete tool to be limited by branch This patch makes the bulk patron delete/anonymize functionality be limited by branch. It does so by adding a branch selection dropdown and using the already defined APIs for filtering by branch. It makes use of C4::Branches::onlymine for the IndependentBranches use case and it adds a way to call it from the Branches template plugin. To test: - Apply the patch 1) Have a superlibrarian user - Go to Tools > Batch patron deletion/anonymization => SUCCESS: Verify you can pick a branch (or all of them) - Try doing some operations => SUCCESS: Verify the selection is respected, and carried around all steps 2) Have a user with tools/delete_anonymize_patrons permissions - Set IndependentBranches on - Go to Tools > Batch patron deletion/anonymization => SUCCESS: It picks the librarian's branch and doesn't let us choose another one - Try doing some operations => SUCCESS: Verify the user's branch is respected, and carried around all steps - Sign off :-D Sponsored-by: VOKAL Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15540] Debian package option to set up an .onion address ( Tor hidden service) for the OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15540 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz(a)catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Liz Rea <liz(a)catalyst.net.nz> --- Hi Mirko, It looks like this doesn't apply anymore. :( Applying: Bug 15540 - Debian package option to set up an .onion address (Tor hidden service) for the OPAC Using index info to reconstruct a base tree... M debian/docs/koha-create.xml M debian/scripts/koha-create M debian/scripts/koha-remove Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-remove Auto-merging debian/scripts/koha-create CONFLICT (content): Merge conflict in debian/scripts/koha-create Auto-merging debian/docs/koha-create.xml CONFLICT (content): Merge conflict in debian/docs/koha-create.xml Liz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz(a)catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #15 from Liz Rea <liz(a)catalyst.net.nz> --- Hi, I have both the test failing: t/db_dependent/Reserves/IsHoldNoteRequired.t .. 1..3 ok 1 - Should be false if plugins are disabled not ok 2 - Should be true for biblionumber 2 # Failed test 'Should be true for biblionumber 2' # at t/db_dependent/Reserves/IsHoldNoteRequired.t line 53. # got: undef # expected: '1' ok 3 - Should be false for biblionumber 0 # Looks like you failed 1 test of 3. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/Reserves/IsHoldNoteRequired.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 2 wallclock secs ( 0.01 usr 0.00 sys + 0.99 cusr 0.05 csys = 1.05 CPU) Result: FAIL And I can't seem to make it work functionally either, sorry. Liz -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15582] Ability to block auto renewals if the OPACFineNoRenewals amount is reached
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15582 Liz Rea <liz(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz(a)catalyst.net.nz --- Comment #15 from Liz Rea <liz(a)catalyst.net.nz> --- Applying: Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15582: Ability to block auto renewals if OPACFineNoRenewals is reached -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 18 Jul '16

18 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marcel de Rooy from comment #26) > (In reply to M. Tompsett from comment #23) > > ::: misc/stage_file.pl > > @@ +85,4 @@ > > > > > > my $dbh = C4::Context->dbh; > > > $dbh->{AutoCommit} = 0; > > > +process_batch($format, $input_file, $record_type, $match, $add_items, $batch_comment); > > > > Could we hashref this, please? > > We should not per se hashref to hashref imo. This is just a local sub of one > script. But seeing the mix of parameters and file level vars, I decided to > do it after all. Hopefully a slight improvement of the code. Why did you change everything to the hashref references? my ($parameters) = @_; my $format = $parameters->{format}; ... block at the top and all the other code wouldn't need to be changed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '16

17 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0