July 2016 - Koha-bugs - lists.koha-community.org

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51326|0 |1 is obsolete| | --- Comment #128 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53444&action=ed… Bug 11592: MARCView and ISBD followup There are still some leaks, but it is not as a result of the filter, but rather a result of poorly written template files. Bug fixing template files is beyond the scope of this set of patches. TEST PLAN --------- 1) Backup your DB 2) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=-8; -- this should set EVERYTHING to hidden across the board. 3) In staff client, set OPACXSLTDetailsDisplay to blank 4) In OPAC, view any detail. -- Normal view may mostly leak values still. -- MARC view may leak values. -- ISBD view may leak values. 5) In staff client, set OPACXSLTDetailsDisplay to default 6) In OPAC, view any detail. -- same issues as step 4 -- 'View Plain' may leak too. 7) 'Save record' -> 'Dublin Core' 8) Apply this patch 9) run koha qa test tools -- should be fine 10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t -- should pass -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too 11) In OPAC, view any detail. -- Normal view: -- Material type comes from the LEADER field. -- Lists this is on will still display -- 'Tags from this library' will still display -- Item information in table will still display (THIS IS BEYOND SCOPE) -- MARC view: -- Record number is leaked (THIS IS BEYOND SCOPE) -- 'View plain' leaks LEADER field. -- ISBD view may leak field headings, but not values. (THIS IS BEYOND SCOPE) 12) In staff client, set OPACXSLTDetailsDisplay to blank 13) In OPAC, view any detail. -- same kind of output as step 10 14) 'Save record' -> BIBTEXT -- Should be next to nothing leaked. 15) 'Save record' -> Dublin Core -- Should be the same or less leaked between the two versions. -- (XML FILTERING IS BEYOND SCOPE) 16) In the staff client, go view the same record. -- it should be mostly hidden in ISBD View. 17) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=1; -- this should set EVERYTHING to hidden in OPAC, but not the STAFF across the board. 18) Refresh the staff ISBD page -- values should reappear. 19) View the ISBD details in the OPAC -- values should still be hidden. 20) Check out the OPAC Cart and List -- while the intermediate pages may still leak the download links should leak very minimally. -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH THE INTRANET ISBD AND SOME CART/LIST STUFF WERE FIXED BECAUSE OF THE GetISBDView REFACTOR) Expectations: Before Patch - all the OPAC Detail pages will display things After Patch - all the OPAC Detail pages will display much less, and hopefully nothing (though there are known limits). the ISBD detail page in the Staff client will be filtered as well based on STAFF settings. The saving/exporting should generate nearly empty files. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51316|0 |1 is obsolete| | --- Comment #127 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53443&action=ed… Biblio tweak for MARCSUBJECT https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51315|0 |1 is obsolete| | --- Comment #126 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53442&action=ed… Applying filtering to opac interface. Applying the filtering and then... Debugging opac/opac-detail.pl filtering Debugging opac/opac-ISBDdetail.pl more Debugging opac/opac-export.pl Tweak opac/opac-export.pl fix variable declarations, conditional assignments Debugging opac/opac-showmarc.pl https://bugs.koha-community.org/show_bug.cgi?id=11592 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51314|0 |1 is obsolete| | --- Comment #125 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53441&action=ed… Bug 11592 - Add should_hide_marc method to filter Add should_hide_marc to ViewPolicy filter Add should_hide_marc tests to t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51313|0 |1 is obsolete| | --- Comment #124 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 53440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53440&action=ed… Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat <robin(a)catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Brendan Gallagher <brendan(a)bywatersolutions.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14138] Patroncard: Warn user if PDF creation fails
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #17 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16856] New: unimarc plugin 4xx template noise
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 Bug ID: 16856 Summary: unimarc plugin 4xx template noise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Running prove t/db_dependent/FrameworkPlugin.t triggers UNIMARC 4xx plugin noise. Discovered while fixing 10148. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #83 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Looks good! Pushed to master for 16.11! Thanks Colin, Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0